fix: This release addresses a regression in the IBM Cloud Provider v1.50.0 [generating an 'Unprocessable Entity](IBM-Cloud/terraform-provider-ibm#4339) when passing a null auto scaling option (#74)

Author: shemau

README.md

@@ -68,7 +68,7 @@ You need the following permissions to run this module.
 | Name | Description | Type | Default | Required |
 |------|-------------|------|---------|:--------:|
 | <a name="input_allowlist"></a> [allowlist](#input\_allowlist) | (Optional, List of Objects) A list of allowed IP addresses for the database. | <pre>list(object({<br>    address     = string<br>    description = string<br>  }))</pre> | `[]` | no |
-| <a name="input_auto_scaling"></a> [auto\_scaling](#input\_auto\_scaling) | Configure rules to allow your database to automatically increase its resources. Single block of autoscaling is allowed at once. | <pre>object({<br>    cpu = object({<br>      rate_increase_percent       = optional(number)<br>      rate_limit_count_per_member = optional(number)<br>      rate_period_seconds         = optional(number)<br>      rate_units                  = optional(string)<br>    })<br>    disk = object({<br>      capacity_enabled             = optional(bool)<br>      free_space_less_than_percent = optional(number)<br>      io_above_percent             = optional(number)<br>      io_over_period               = optional(string)<br>      io_enabled                   = optional(bool)<br>      rate_increase_percent        = optional(number)<br>      rate_limit_mb_per_member     = optional(number)<br>      rate_period_seconds          = optional(number)<br>      rate_units                   = optional(string)<br>    })<br>    memory = object({<br>      io_above_percent         = optional(number)<br>      io_enabled               = optional(bool)<br>      io_over_period           = optional(string)<br>      rate_increase_percent    = optional(number)<br>      rate_limit_mb_per_member = optional(number)<br>      rate_period_seconds      = optional(number)<br>      rate_units               = optional(string)<br>    })<br>  })</pre> | <pre>{<br>  "cpu": {},<br>  "disk": {},<br>  "memory": {}<br>}</pre> | no |
+| <a name="input_auto_scaling"></a> [auto\_scaling](#input\_auto\_scaling) | Configure rules to allow your database to automatically increase its resources. Single block of autoscaling is allowed at once. | <pre>object({<br>    cpu = object({<br>      rate_increase_percent       = optional(number, 10)<br>      rate_limit_count_per_member = optional(number, 20)<br>      rate_period_seconds         = optional(number, 900)<br>      rate_units                  = optional(string, "count")<br>    })<br>    disk = object({<br>      capacity_enabled             = optional(bool, false)<br>      free_space_less_than_percent = optional(number, 10)<br>      io_above_percent             = optional(number, 90)<br>      io_enabled                   = optional(bool, false)<br>      io_over_period               = optional(string, "15m")<br>      rate_increase_percent        = optional(number, 10)<br>      rate_limit_mb_per_member     = optional(number, 3670016)<br>      rate_period_seconds          = optional(number, 900)<br>      rate_units                   = optional(string, "mb")<br>    })<br>    memory = object({<br>      io_above_percent         = optional(number, 90)<br>      io_enabled               = optional(bool, false)<br>      io_over_period           = optional(string, "15m")<br>      rate_increase_percent    = optional(number, 10)<br>      rate_limit_mb_per_member = optional(number, 114688)<br>      rate_period_seconds      = optional(number, 900)<br>      rate_units               = optional(string, "mb")<br>    })<br>  })</pre> | `null` | no |
 | <a name="input_backup_encryption_key_crn"></a> [backup\_encryption\_key\_crn](#input\_backup\_encryption\_key\_crn) | (Optional) The CRN of a key protect key, that you want to use for encrypting disk that holds deployment backups. If null, will use 'key\_protect\_key\_crn' as encryption key. If 'key\_protect\_key\_crn' is also null database is encrypted by using randomly generated keys. | `string` | `null` | no |
 | <a name="input_cbr_rules"></a> [cbr\_rules](#input\_cbr\_rules) | (Optional, list) List of CBR rules to create | <pre>list(object({<br>    description = string<br>    account_id  = string<br>    rule_contexts = list(object({<br>      attributes = optional(list(object({<br>        name  = string<br>        value = string<br>    }))) }))<br>    enforcement_mode = string<br>  }))</pre> | `[]` | no |
 | <a name="input_configuration"></a> [configuration](#input\_configuration) | Database Configuration in JSON format. | <pre>object({<br>    maxmemory                   = optional(number)<br>    maxmemory-policy            = optional(string)<br>    appendonly                  = optional(string)<br>    maxmemory-samples           = optional(number)<br>    stop-writes-on-bgsave-error = optional(string)<br>  })</pre> | `null` | no |

examples/autoscale/variables.tf

@@ -40,8 +40,8 @@ variable "auto_scaling" {
       capacity_enabled             = optional(bool)
       free_space_less_than_percent = optional(number)
       io_above_percent             = optional(number)
-      io_over_period               = optional(string)
       io_enabled                   = optional(bool)
+      io_over_period               = optional(string)
       rate_increase_percent        = optional(number)
       rate_limit_mb_per_member     = optional(number)
       rate_period_seconds          = optional(number)
@@ -59,31 +59,13 @@ variable "auto_scaling" {
   })
   description = "Configure rules to allow your database to automatically increase its resources. Single block of autoscaling is allowed at once."
   default = {
-    cpu = {
-      rate_increase_percent       = 20
-      rate_limit_count_per_member = 20
-      rate_period_seconds         = 900
-      rate_units                  = "count"
-    }
+    cpu = {}
     disk = {
-      capacity_enabled             = true
-      free_space_less_than_percent = 15
-      io_above_percent             = 85
-      io_enabled                   = true
-      io_over_period               = "15m"
-      rate_increase_percent        = 15
-      rate_limit_mb_per_member     = 3670016
-      rate_period_seconds          = 900
-      rate_units                   = "mb"
+      capacity_enabled : true,
+      io_enabled : true
     }
     memory = {
-      io_above_percent         = 90
-      io_enabled               = true
-      io_over_period           = "15m"
-      rate_increase_percent    = 10
-      rate_limit_mb_per_member = 114688
-      rate_period_seconds      = 900
-      rate_units               = "mb"
+      io_enabled : true,
     }
   }
 }

main.tf

@@ -2,7 +2,8 @@
 # This file is used to implement the ROOT module
 *********************************************************************/
 locals {
-  kp_backup_crn = var.backup_encryption_key_crn != null ? var.backup_encryption_key_crn : var.key_protect_key_crn
+  kp_backup_crn        = var.backup_encryption_key_crn != null ? var.backup_encryption_key_crn : var.key_protect_key_crn
+  auto_scaling_enabled = var.auto_scaling == null ? [] : [1]
 }
 
 resource "ibm_database" "mongodb" {
@@ -20,32 +21,37 @@ resource "ibm_database" "mongodb" {
 
   configuration = var.configuration != null ? jsonencode(var.configuration) : null
 
-  auto_scaling {
-    cpu {
-      rate_increase_percent       = var.auto_scaling.cpu.rate_increase_percent
-      rate_limit_count_per_member = var.auto_scaling.cpu.rate_limit_count_per_member
-      rate_period_seconds         = var.auto_scaling.cpu.rate_period_seconds
-      rate_units                  = var.auto_scaling.cpu.rate_units
-    }
-    disk {
-      capacity_enabled             = var.auto_scaling.disk.capacity_enabled
-      free_space_less_than_percent = var.auto_scaling.disk.free_space_less_than_percent
-      io_above_percent             = var.auto_scaling.disk.io_above_percent
-      io_enabled                   = var.auto_scaling.disk.io_enabled
-      io_over_period               = var.auto_scaling.disk.io_over_period
-      rate_increase_percent        = var.auto_scaling.disk.rate_increase_percent
-      rate_limit_mb_per_member     = var.auto_scaling.disk.rate_limit_mb_per_member
-      rate_period_seconds          = var.auto_scaling.disk.rate_period_seconds
-      rate_units                   = var.auto_scaling.disk.rate_units
-    }
-    memory {
-      io_above_percent         = var.auto_scaling.memory.io_above_percent
-      io_enabled               = var.auto_scaling.memory.io_enabled
-      io_over_period           = var.auto_scaling.memory.io_over_period
-      rate_increase_percent    = var.auto_scaling.memory.rate_increase_percent
-      rate_limit_mb_per_member = var.auto_scaling.memory.rate_limit_mb_per_member
-      rate_period_seconds      = var.auto_scaling.memory.rate_period_seconds
-      rate_units               = var.auto_scaling.memory.rate_units
+  ## This for_each block is NOT a loop to attach to multiple auto_scaling blocks.
+  ## This block is only used to conditionally add auto_scaling block depending on var.auto_scaling
+  dynamic "auto_scaling" {
+    for_each = local.auto_scaling_enabled
+    content {
+      cpu {
+        rate_increase_percent       = var.auto_scaling.cpu.rate_increase_percent
+        rate_limit_count_per_member = var.auto_scaling.cpu.rate_limit_count_per_member
+        rate_period_seconds         = var.auto_scaling.cpu.rate_period_seconds
+        rate_units                  = var.auto_scaling.cpu.rate_units
+      }
+      disk {
+        capacity_enabled             = var.auto_scaling.disk.capacity_enabled
+        free_space_less_than_percent = var.auto_scaling.disk.free_space_less_than_percent
+        io_above_percent             = var.auto_scaling.disk.io_above_percent
+        io_enabled                   = var.auto_scaling.disk.io_enabled
+        io_over_period               = var.auto_scaling.disk.io_over_period
+        rate_increase_percent        = var.auto_scaling.disk.rate_increase_percent
+        rate_limit_mb_per_member     = var.auto_scaling.disk.rate_limit_mb_per_member
+        rate_period_seconds          = var.auto_scaling.disk.rate_period_seconds
+        rate_units                   = var.auto_scaling.disk.rate_units
+      }
+      memory {
+        io_above_percent         = var.auto_scaling.memory.io_above_percent
+        io_enabled               = var.auto_scaling.memory.io_enabled
+        io_over_period           = var.auto_scaling.memory.io_over_period
+        rate_increase_percent    = var.auto_scaling.memory.rate_increase_percent
+        rate_limit_mb_per_member = var.auto_scaling.memory.rate_limit_mb_per_member
+        rate_period_seconds      = var.auto_scaling.memory.rate_period_seconds
+        rate_units               = var.auto_scaling.memory.rate_units
+      }
     }
   }
 

module-metadata.json

@@ -13,13 +13,8 @@
     },
     "auto_scaling": {
       "name": "auto_scaling",
-      "type": "object({\n    cpu = object({\n      rate_increase_percent       = optional(number)\n      rate_limit_count_per_member = optional(number)\n      rate_period_seconds         = optional(number)\n      rate_units                  = optional(string)\n    })\n    disk = object({\n      capacity_enabled             = optional(bool)\n      free_space_less_than_percent = optional(number)\n      io_above_percent             = optional(number)\n      io_over_period               = optional(string)\n      io_enabled                   = optional(bool)\n      rate_increase_percent        = optional(number)\n      rate_limit_mb_per_member     = optional(number)\n      rate_period_seconds          = optional(number)\n      rate_units                   = optional(string)\n    })\n    memory = object({\n      io_above_percent         = optional(number)\n      io_enabled               = optional(bool)\n      io_over_period           = optional(string)\n      rate_increase_percent    = optional(number)\n      rate_limit_mb_per_member = optional(number)\n      rate_period_seconds      = optional(number)\n      rate_units               = optional(string)\n    })\n  })",
+      "type": "object({\n    cpu = object({\n      rate_increase_percent       = optional(number, 10)\n      rate_limit_count_per_member = optional(number, 20)\n      rate_period_seconds         = optional(number, 900)\n      rate_units                  = optional(string, \"count\")\n    })\n    disk = object({\n      capacity_enabled             = optional(bool, false)\n      free_space_less_than_percent = optional(number, 10)\n      io_above_percent             = optional(number, 90)\n      io_enabled                   = optional(bool, false)\n      io_over_period               = optional(string, \"15m\")\n      rate_increase_percent        = optional(number, 10)\n      rate_limit_mb_per_member     = optional(number, 3670016)\n      rate_period_seconds          = optional(number, 900)\n      rate_units                   = optional(string, \"mb\")\n    })\n    memory = object({\n      io_above_percent         = optional(number, 90)\n      io_enabled               = optional(bool, false)\n      io_over_period           = optional(string, \"15m\")\n      rate_increase_percent    = optional(number, 10)\n      rate_limit_mb_per_member = optional(number, 114688)\n      rate_period_seconds      = optional(number, 900)\n      rate_units               = optional(string, \"mb\")\n    })\n  })",
       "description": "Configure rules to allow your database to automatically increase its resources. Single block of autoscaling is allowed at once.",
-      "default": {
-        "cpu": {},
-        "disk": {},
-        "memory": {}
-      },
       "pos": {
         "filename": "variables.tf",
         "line": 147
@@ -48,7 +43,7 @@
       ],
       "pos": {
         "filename": "variables.tf",
-        "line": 186
+        "line": 182
       }
     },
     "configuration": {
@@ -284,7 +279,7 @@
       },
       "pos": {
         "filename": "main.tf",
-        "line": 8
+        "line": 9
       }
     }
   },
@@ -363,7 +358,7 @@
       },
       "pos": {
         "filename": "main.tf",
-        "line": 93
+        "line": 99
       }
     }
   }

variables.tf

@@ -147,38 +147,34 @@ variable "members" {
 variable "auto_scaling" {
   type = object({
     cpu = object({
-      rate_increase_percent       = optional(number)
-      rate_limit_count_per_member = optional(number)
-      rate_period_seconds         = optional(number)
-      rate_units                  = optional(string)
+      rate_increase_percent       = optional(number, 10)
+      rate_limit_count_per_member = optional(number, 20)
+      rate_period_seconds         = optional(number, 900)
+      rate_units                  = optional(string, "count")
     })
     disk = object({
-      capacity_enabled             = optional(bool)
-      free_space_less_than_percent = optional(number)
-      io_above_percent             = optional(number)
-      io_over_period               = optional(string)
-      io_enabled                   = optional(bool)
-      rate_increase_percent        = optional(number)
-      rate_limit_mb_per_member     = optional(number)
-      rate_period_seconds          = optional(number)
-      rate_units                   = optional(string)
+      capacity_enabled             = optional(bool, false)
+      free_space_less_than_percent = optional(number, 10)
+      io_above_percent             = optional(number, 90)
+      io_enabled                   = optional(bool, false)
+      io_over_period               = optional(string, "15m")
+      rate_increase_percent        = optional(number, 10)
+      rate_limit_mb_per_member     = optional(number, 3670016)
+      rate_period_seconds          = optional(number, 900)
+      rate_units                   = optional(string, "mb")
     })
     memory = object({
-      io_above_percent         = optional(number)
-      io_enabled               = optional(bool)
-      io_over_period           = optional(string)
-      rate_increase_percent    = optional(number)
-      rate_limit_mb_per_member = optional(number)
-      rate_period_seconds      = optional(number)
-      rate_units               = optional(string)
+      io_above_percent         = optional(number, 90)
+      io_enabled               = optional(bool, false)
+      io_over_period           = optional(string, "15m")
+      rate_increase_percent    = optional(number, 10)
+      rate_limit_mb_per_member = optional(number, 114688)
+      rate_period_seconds      = optional(number, 900)
+      rate_units               = optional(string, "mb")
     })
   })
   description = "Configure rules to allow your database to automatically increase its resources. Single block of autoscaling is allowed at once."
-  default = {
-    cpu    = {}
-    disk   = {}
-    memory = {}
-  }
+  default     = null
 }
 ##############################################################
 # Context-based restriction (CBR)