generated from terraform-ibm-modules/terraform-ibm-module-template
-
Notifications
You must be signed in to change notification settings - Fork 1
fix: deduplicate auth policy #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/run pipeline |
Contributor
Author
|
As expected the problem is on the main branch and the upgrade test will have to be skipped. TestRunCompleteUpgradeExample 2025-01-28T15:52:27Z retry.go:99: Returning due to fatal error: FatalError{Underlying: error while running command: exit status 1; ╷
Error: [0m Error: [ERROR] Error creating authorization policy: The policy wasn't created because an access policy with identical attributes and roles already exists. Please update the rule in the existing policy (f925a045-264c-4e7c-98db-668ecee49f75), or update the one you're trying to assign to include a different attribute assignment. { |
Contributor
Author
|
/run pipeline |
ocofaigh
approved these changes
Jan 28, 2025
Contributor
Author
|
/run pipeline |
3 similar comments
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
Contributor
|
🎉 This PR is included in version 2.14.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is an issue on the main branch with the complete example where both the data store encryption key and backup encryption key are the same. The authorization has been moved from KMS instance to the key, so when only one key is used the policy will conflict (duplicate policy).
This in the example/test code and thus no release is required.
Since it is on the main branch, the upgrade should fail; which will require running the tests without an upgrade for this.
Historically, AFAIK, it was possible to use the same key for both the instance and the backup. This means a previous change must have been a breaking change, in that if the same key was used for both it is now broken. You can not use the same key on redeploy/upgrade of an existing deployment. You either hit the conflicting auth policy, or you have to change the backup key, which I don't think is allowed. Further investigation required.
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers