Skip to content

feat: updated code to use cross-object referencing for validations #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
May 1, 2025
Merged

feat: updated code to use cross-object referencing for validations #485

merged 21 commits into from
May 1, 2025

Conversation

@Khuzaima05
Copy link
Member

@Khuzaima05 Khuzaima05 commented Feb 12, 2025 •
edited
Loading

Description

updated code to use cross-object referencing for validations

issue:https://github.ibm.com/GoldenEye/issues/issues/12400

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

This PR adds cross object referencing for input variable validation

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Khuzaima05 Khuzaima05 self-assigned this Feb 12, 2025
@Khuzaima05
Copy link
Member Author

Khuzaima05 commented Feb 12, 2025

/run pipeline

shemau
shemau requested changes Feb 12, 2025
View reviewed changes
@Khuzaima05
Copy link
Member Author

Khuzaima05 commented Feb 18, 2025

/run pipeline

@Khuzaima05
Copy link
Member Author

Khuzaima05 commented Feb 18, 2025

/run pipeline

@Khuzaima05
Copy link
Member Author

Khuzaima05 commented Feb 28, 2025

/run pipeline

@Khuzaima05
Copy link
Member Author

Khuzaima05 commented Mar 3, 2025

/run pipeline

@Khuzaima05
Copy link
Member Author

Khuzaima05 commented Mar 12, 2025

/run pipeline

@Khuzaima05
Copy link
Member Author

Khuzaima05 commented Mar 20, 2025

/run pipeline

@Khuzaima05
Copy link
Member Author

Khuzaima05 commented Apr 7, 2025

/run pipeline

@Khuzaima05
Copy link
Member Author

Khuzaima05 commented Apr 11, 2025

/run pipeline

@Khuzaima05
Copy link
Member Author

Khuzaima05 commented Apr 14, 2025

/run pipeline

@Khuzaima05
Copy link
Member Author

Khuzaima05 commented Apr 22, 2025

/run pipeline

@Khuzaima05
Copy link
Member Author

Khuzaima05 commented Apr 28, 2025

/run pipeline

shemau
shemau approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maheshwarishikha maheshwarishikha merged commit 11e46ab into main May 1, 2025
2 checks passed
@maheshwarishikha maheshwarishikha deleted the issue-12400 branch May 1, 2025 05:05
@terraform-ibm-modules-ops
Copy link
Contributor

terraform-ibm-modules-ops commented May 1, 2025

🎉 This PR is included in version 2.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shemau shemau shemau approved these changes

@rajatagarwal-ibm rajatagarwal-ibm Awaiting requested review from rajatagarwal-ibm rajatagarwal-ibm is a code owner

Assignees

@Khuzaima05 Khuzaima05

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Khuzaima05 @terraform-ibm-modules-ops @shemau @maheshwarishikha