Skip to content

Conversation

@aatreyee2506
Copy link
Contributor

@aatreyee2506 aatreyee2506 commented Feb 24, 2025

Description

Added tests and missing examples to make MongoDB consistent.
Git issue

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

NEW RELEASE: Adds support for MongoDB 7.0

Address consistency issues:

Issues addressed that require code changes to upgrade:

  • Input instance_name renamed to name
  • Input endpoints renamed to service_endpoints
  • Input cpu_count renamed to member_cpu_count
  • Input disk_mb renamed to member_disk_mb
  • Input memory_mb renamed to member_memory_mb
  • Required terraform version update from 1.3.0 to 1.9.0

Issues addressed in the deployable architecture

  • Removed cbr_rule_ids, adminuser and certificate_base64 outputs.
  • Added input existing_db_instance_crn, admin_pass_secret_manager_secret_group, use_existing_admin_pass_secret_manager_secret_group and admin_pass_secret_manager_secret_name inputs.
  • Support for passing an existing instance

Issues addressed that do not require code changes to upgrade:

  • Adds missing examples to cover restoring from backup
  • Balanced tests to improve coverage with fewer resources

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@aatreyee2506
Copy link
Contributor Author

/run pipeline

@aatreyee2506
Copy link
Contributor Author

/run pipeline

Aatreyee Mukherjee added 2 commits February 26, 2025 23:39
@aatreyee2506
Copy link
Contributor Author

/run pipeline

@aatreyee2506
Copy link
Contributor Author

/run pipeline

@aatreyee2506
Copy link
Contributor Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Member

/run pipeline

@aatreyee2506
Copy link
Contributor Author

/run pipeline

@aatreyee2506 aatreyee2506 marked this pull request as ready for review March 3, 2025 13:04
@aatreyee2506
Copy link
Contributor Author

/run pipeline

shemau
shemau previously approved these changes Mar 3, 2025
Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aatreyee2506
Copy link
Contributor Author

Working on adding PITR.

@aatreyee2506
Copy link
Contributor Author

/run pipeline

@aatreyee2506
Copy link
Contributor Author

/run pipeline

@aatreyee2506
Copy link
Contributor Author

/run pipeline

@aatreyee2506
Copy link
Contributor Author

member_host_flavour is not set on the mongodb resource instance. Originally, we needed to pass a group block when creating the instance. However, due to a bug in the provider, we had to remove the group block for restore operations (from backup, from PITR) and for read-only replicas.

@aatreyee2506
Copy link
Contributor Author

/run pipeline

@aatreyee2506
Copy link
Contributor Author

/run pipeline

@aatreyee2506
Copy link
Contributor Author

/run pipeline

Copy link
Member

@Aashiq-J Aashiq-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other ICD PRs I see that

  • member_cpu_count renamed to cpu_count
  • member_disk_mb renamed to disk_mb
  • member_memory_mb renamed to memory_mb
  • resource_tags renamed to tags

but in this PR it is the other way around.

@aatreyee2506
Copy link
Contributor Author

/run pipeline

@aatreyee2506 aatreyee2506 requested a review from Aashiq-J April 3, 2025 06:27
@aatreyee2506
Copy link
Contributor Author

/run pipeline

@aatreyee2506
Copy link
Contributor Author

/run pipeline

@aatreyee2506
Copy link
Contributor Author

/run pipeline

@Aashiq-J Aashiq-J merged commit e9d2580 into main Apr 11, 2025
2 checks passed
@Aashiq-J Aashiq-J deleted the test-coverage branch April 11, 2025 05:47
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants