Skip to content

Conversation

@Khuzaima05
Copy link
Member

@Khuzaima05 Khuzaima05 commented Apr 29, 2025

Description

renamed the 'tags' variables in examples

issue: https://github.ibm.com/GoldenEye/issues/issues/13410

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

This issue update Test functions in other_test.go pipeline

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

@Khuzaima05 Khuzaima05 changed the title fix: updated the other_test.go to use TestOptionsDefault function fix: renamed the 'tags' variables in examples May 2, 2025
@Khuzaima05
Copy link
Member Author

/run pipeline

Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocofaigh ocofaigh merged commit 050a1d2 into main May 2, 2025
2 checks passed
@ocofaigh ocofaigh deleted the issue_13410 branch May 2, 2025 10:18
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.18.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants