Skip to content

Conversation

@whoffler
Copy link
Contributor

@whoffler whoffler commented May 9, 2025

Description

Fully Configurable + Security Enforced solutions

for issue - https://github.ibm.com/GoldenEye/issues/issues/13007

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@whoffler
Copy link
Contributor Author

whoffler commented May 9, 2025

/run pipeline

1 similar comment
@whoffler
Copy link
Contributor Author

whoffler commented May 9, 2025

/run pipeline

@whoffler whoffler force-pushed the fullyConfigurable branch from 5df714d to 788a3cf Compare May 12, 2025 07:54
@whoffler
Copy link
Contributor Author

/run pipeline

@whoffler whoffler force-pushed the fullyConfigurable branch from 788a3cf to 3725d5c Compare May 12, 2025 07:56
@whoffler
Copy link
Contributor Author

/run pipeline

@whoffler whoffler force-pushed the fullyConfigurable branch from 3725d5c to fb398df Compare May 12, 2025 08:05
@whoffler
Copy link
Contributor Author

/run pipeline

@whoffler whoffler force-pushed the fullyConfigurable branch from fb398df to 921aec5 Compare May 12, 2025 08:12
@whoffler
Copy link
Contributor Author

/run pipeline

3 similar comments
@whoffler
Copy link
Contributor Author

/run pipeline

@whoffler
Copy link
Contributor Author

/run pipeline

@shemau
Copy link
Contributor

shemau commented Jun 6, 2025

/run pipeline

@whoffler whoffler force-pushed the fullyConfigurable branch 2 times, most recently from 5da2c0b to 8094df2 Compare June 21, 2025 17:09
@whoffler
Copy link
Contributor Author

/run pipeline

@whoffler whoffler force-pushed the fullyConfigurable branch from 8094df2 to b95f7e3 Compare June 21, 2025 20:25
@whoffler whoffler force-pushed the fullyConfigurable branch from b95f7e3 to 683efb5 Compare June 22, 2025 08:02
@whoffler
Copy link
Contributor Author

/run pipeline

@whoffler
Copy link
Contributor Author

/run pipeline

@whoffler
Copy link
Contributor Author

/run pipeline

@whoffler
Copy link
Contributor Author

/run pipeline

@whoffler
Copy link
Contributor Author

/run pipeline

@whoffler
Copy link
Contributor Author

/run pipeline

@whoffler
Copy link
Contributor Author

/run pipeline

Copy link
Contributor

@akocbek akocbek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make same changes in security as in fully-configurable

variable "members" {
type = number
description = "The number of members that are allocated. [Learn more](https://cloud.ibm.com/docs/databases-for-mongodb?topic=databases-for-mongodb-resources-scaling)."
default = 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be 2? sync with redis

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MongoDB needs 3.

@whoffler whoffler force-pushed the fullyConfigurable branch from 884fb22 to 785b430 Compare June 27, 2025 14:01
@whoffler
Copy link
Contributor Author

/run pipeline

@akocbek
Copy link
Contributor

akocbek commented Jun 27, 2025

/run pipeline

Copy link
Contributor

@akocbek akocbek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ocofaigh ocofaigh merged commit cf08270 into main Jun 27, 2025
2 checks passed
@ocofaigh ocofaigh deleted the fullyConfigurable branch June 27, 2025 14:48
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants