-
Notifications
You must be signed in to change notification settings - Fork 1
Fully configurable and Security enforced DAs #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
1 similar comment
|
/run pipeline |
5df714d to
788a3cf
Compare
|
/run pipeline |
788a3cf to
3725d5c
Compare
|
/run pipeline |
3725d5c to
fb398df
Compare
|
/run pipeline |
fb398df to
921aec5
Compare
|
/run pipeline |
3 similar comments
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
5da2c0b to
8094df2
Compare
|
/run pipeline |
8094df2 to
b95f7e3
Compare
b95f7e3 to
683efb5
Compare
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
akocbek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make same changes in security as in fully-configurable
solutions/fully-configurable/catalogValidationValues.json.template
Outdated
Show resolved
Hide resolved
| variable "members" { | ||
| type = number | ||
| description = "The number of members that are allocated. [Learn more](https://cloud.ibm.com/docs/databases-for-mongodb?topic=databases-for-mongodb-resources-scaling)." | ||
| default = 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be 2? sync with redis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MongoDB needs 3.
solutions/security-enforced/catalogValidationValues.json.template
Outdated
Show resolved
Hide resolved
884fb22 to
785b430
Compare
|
/run pipeline |
|
/run pipeline |
akocbek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Fully Configurable + Security Enforced solutions
for issue - https://github.ibm.com/GoldenEye/issues/issues/13007
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers