fix: vpe tests SKIP UPGRADE TESTS

Author: Jordan-Williams2

solutions/standard/main.tf

@@ -229,7 +229,7 @@ resource "random_password" "admin_password" {
 }
 
 locals {
-  # _- are invalid first characters
+  # _- are invalid first characters.
   # if - replace first char with J
   # elseif _ replace first char with K
   # else use asis

tests/pr_test.go

@@ -181,13 +181,20 @@ func TestRunStandardUpgradeSolution(t *testing.T) {
 		ResourceGroup:      resourceGroup,
 	})
 
+	// Generate a 15 char long random string for the admin_pass
+	randomBytes := make([]byte, 13)
+	_, randErr := rand.Read(randomBytes)
+	require.Nil(t, randErr) // do not proceed if we can't gen a random password
+
+	randomPass := "A1" + base64.URLEncoding.EncodeToString(randomBytes)[:13]
+
 	options.TerraformVars = map[string]interface{}{
 		"access_tags":               permanentResources["accessTags"],
 		"existing_kms_instance_crn": permanentResources["hpcs_south_crn"],
 		"kms_endpoint_type":         "public",
 		"provider_visibility":       "public",
 		"resource_group_name":       options.Prefix,
-		"admin_pass":                options.Prefix,
+		"admin_pass":                randomPass,
 	}
 
 	output, err := options.RunTestUpgrade()