Skip to content

Conversation

@jor2
Copy link
Member

@jor2 jor2 commented Nov 21, 2024

Description

#158

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Add workaround to ignore groups config when provisioning instance using backup CRN

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@jor2 jor2 self-assigned this Nov 21, 2024
@jor2
Copy link
Member Author

jor2 commented Nov 21, 2024

/run pipeline

main.tf Outdated
## This block is for if host_flavor IS NOT set
dynamic "group" {
for_each = local.host_flavor_set ? [] : [1]
for_each = local.host_flavor_set && !local.recovery_mode ? [] : [1]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That logic was wrong and later improved in postgresql to:

for_each = local.host_flavor_set == false && !local.recovery_mode ? [1] : []

@jor2
Copy link
Member Author

jor2 commented Nov 25, 2024

/run pipeline

@jor2 jor2 requested a review from shemau November 27, 2024 13:35
Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocofaigh ocofaigh merged commit fd96468 into main Nov 29, 2024
2 checks passed
@ocofaigh ocofaigh deleted the group-fix branch November 29, 2024 12:50
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.3.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants