Skip to content

Conversation

@toddgiguere
Copy link
Member

Description

The minimum values required for read-only-replica for MySQL has changed, updated the basic example to reflect these new limits, which is also part of the unit test.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@toddgiguere toddgiguere requested a review from Ak-sky as a code owner December 6, 2024 17:22
@toddgiguere
Copy link
Member Author

/run pipeline

@toddgiguere
Copy link
Member Author

The PR test does not run the TestRunBasicExample test that I'm trying to fix here, so I ran it manually and it has passed.

--- PASS: TestRunBasicExample (1349.00s)
PASS
ok  	github.com/terraform-ibm-modules/terraform-ibm-icd-mysql	1351.447s

@ocofaigh ocofaigh merged commit d006655 into main Dec 6, 2024
2 checks passed
@ocofaigh ocofaigh deleted the fix-basic-example branch December 6, 2024 18:22
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants