feat: support for configuration

[shemau]

Description

#207

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Add support for passing a configuration block when creating the ICD instance. This includes base module, fscloud sub module and deployable architecture.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[shemau]

The first commit is the basic code.

Todo:

• Find the doc for MySQL and Postgresql. Make sure the right configurations are exposed. Either uncomment or delete the configurations that are commented out. They were not in the original MySQL code, removed in 1.4.0, so this would be a validation that no new options are added.
• Update the test code in tests/*.go. Make the test coverage comparable to Postgresql.

[shemau]

/run pipeline

[shemau]

Nearing completion. One final pass and tidy up before being ready for review.

[shemau]

The upgrade test, failed showing

         	            	Actions: [update]
        	            	DIFF:
        	            	  Before: 
        	            		{"configuration":null}
        	            	  After: 
        	            		{"configuration":"{\"default_authentication_plugin\":\"sha256_password\",\"innodb_buffer_pool_size_percentage\":50,\"innodb_flush_log_at_trx_commit\":2,\"innodb_log_buffer_size\":33554432,\"innodb_log_file_size\":104857600,\"innodb_lru_scan_depth\":256,\"innodb_read_io_threads\":4,\"innodb_write_io_threads\":4,\"max_allowed_packet\":16777216,\"max_connections\":200,\"max_prepared_stmt_count\":16382,\"mysql_max_binlog_age_sec\":1800,\"net_read_timeout\":60,\"net_write_timeout\":60,\"sql_mode\":\"NO_ZERO_IN_DATE,NO_ENGINE_SUBSTITUTION\",\"wait_timeout\":28800}"}        	            		

Which is the new option being added and flagged update in place.

[shemau]

/run pipeline

[shemau]

        	            	Actions: [update]
        	            	DIFF:
        	            	  Before: 
        	            		{"configuration":null}
        	            	  After: 
        	            		{"configuration":"{\"default_authentication_plugin\":\"sha256_password\",\"innodb_buffer_pool_size_percentage\":50,\"innodb_flush_log_at_trx_commit\":2,\"innodb_log_buffer_size\":33554432,\"innodb_log_file_size\":104857600,\"innodb_lru_scan_depth\":256,\"innodb_read_io_threads\":4,\"innodb_write_io_threads\":4,\"max_allowed_packet\":16777216,\"max_connections\":200,\"max_prepared_stmt_count\":16382,\"mysql_max_binlog_age_sec\":1800,\"net_read_timeout\":60,\"net_write_timeout\":60,\"wait_timeout\":28800}"}
        	            		

TestRunStandardUpgradeSolution 2025-02-12T10:40:48Z command.go:185:   ~ update in-place

From the latest run, the only error is the upgrade test adding the new option that PR adds. Thus it is appropriate to skip the upgrade test.

[shemau]

/run pipeline

[shemau]

/run pipeline

[terraform-ibm-modules-ops]

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

• GitHub release
• v1.8.0

Your semantic-release bot 📦🚀