add: cross object referencing #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aditya-ranjan-16
requested review from
Ak-sky and
toddgiguere
as code owners
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
6 tasks
shemau
requested changes
Feb 26, 2025
shemau
requested changes
Feb 26, 2025
Contributor
Author
|
/run pipeline |
Contributor
Author
|
Work was paused on this as More validation are being added in PR : #220 which is now merged Resuming work now |
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
shemau
requested changes
Apr 16, 2025
Contributor
Author
|
/run pipeline |
shemau
approved these changes
Apr 17, 2025
Contributor
shemau
left a comment
shemau
left a comment
There was a problem hiding this comment.
LGTM
This is consistent with rabbitmq which was used as a template
shemau
requested changes
Apr 17, 2025
Contributor
shemau
left a comment
shemau
left a comment
There was a problem hiding this comment.
I think the redis conditions are easier to read. Can we make this module like redis branch cross-object-validation
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
Contributor
|
🎉 This PR is included in version 1.10.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://github.ibm.com/GoldenEye/issues/issues/12401
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
This PR adds cross object referencing for input variable validation
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers