Skip to content

Conversation

@Aditya-ranjan-16
Copy link
Contributor

@Aditya-ranjan-16 Aditya-ranjan-16 commented Feb 26, 2025

Description

https://github.ibm.com/GoldenEye/issues/issues/11682

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Address consistency issues:

Issues addressed that require code changes to upgrade:

  • Renamed resource_tags to tags across multiple files for consistency.
  • Renamed mysql_db module to database in examples/basic/main.tf.

Issues addressed in the deployable architecture:

  • Added support for using an existing MySQL instance (existing_mysql_instance_crn).
  • Changed instance_name to name
  • Removed cbr_rule_ids, adminuser and certificate_base64 outputs.
  • Added input admin_pass_secret_manager_secret_group, use_existing_admin_pass_secret_manager_secret_group and admin_pass_secret_manager_secret_name inputs.

Issues addressed that do not require code changes to upgrade:

  • Balanced tests to improve coverage with fewer resources

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aditya-ranjan-16 Aditya-ranjan-16 marked this pull request as ready for review March 3, 2025 06:11
@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16 Aditya-ranjan-16 changed the title feat: added missing examples and plugged test gaps feat: consistency with other ICD modules Mar 5, 2025
@Aditya-ranjan-16
Copy link
Contributor Author

@shemau do we need to provision another permanent mysql instance for the backup-restore test for now I have used the mysqlPITRCrn for both TestRunRestoredDBExample and TestRunPointInTimeRecoveryDBExample

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

1 similar comment
@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16 Aditya-ranjan-16 requested a review from shemau March 25, 2025 10:31
Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aashiq-J Aashiq-J merged commit 5296138 into main Apr 2, 2025
2 checks passed
@Aashiq-J Aashiq-J deleted the test-coverage branch April 2, 2025 11:43
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants