-
Notifications
You must be signed in to change notification settings - Fork 2
feat: consistency with other ICD modules #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
@shemau do we need to provision another permanent mysql instance for the backup-restore test for now I have used the |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
1 similar comment
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
shemau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
/run pipeline |
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
https://github.ibm.com/GoldenEye/issues/issues/11682
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Address consistency issues:
Issues addressed that require code changes to upgrade:
resource_tagstotagsacross multiple files for consistency.mysql_dbmodule todatabaseinexamples/basic/main.tf.Issues addressed in the deployable architecture:
existing_mysql_instance_crn).instance_nametonamecbr_rule_ids,adminuserandcertificate_base64outputs.admin_pass_secret_manager_secret_group,use_existing_admin_pass_secret_manager_secret_groupandadmin_pass_secret_manager_secret_nameinputs.Issues addressed that do not require code changes to upgrade:
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers