Skip to content

Conversation

@shemau
Copy link
Contributor

@shemau shemau commented Mar 31, 2025

Description

Manually bump modules used is tests. The VPC upgrade will introduce a resource name change, which can be safely ignored, since it used only for testing (and not in the main module itself).

Only the tests are changing, so no need to create a release.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@shemau
Copy link
Contributor Author

shemau commented Mar 31, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Mar 31, 2025

The following error is detected during upgrade:

         	Messages:   	Resource(s) identified to be updated 
        	            	Name: vpc
        	            	Address: module.vpc.ibm_is_vpc.vpc[0]
        	            	Actions: [update]
        	            	DIFF:
        	            	  Before: 
        	            		{"name":"mysql-upg-8oze5q-vpc-vpc"}
        	            	  After: 
        	            		{"name":"mysql-upg-8oze5q-vpc"}

Since this is in a test and unrelated to this module and was the only error reported, the upgrade tests can be skipped.

@shemau
Copy link
Contributor Author

shemau commented Mar 31, 2025

/run pipeline

@shemau shemau mentioned this pull request Mar 31, 2025
1 task
@ocofaigh
Copy link
Contributor

ocofaigh commented Apr 4, 2025

/run pipeline

1 similar comment
@shemau
Copy link
Contributor Author

shemau commented Apr 4, 2025

/run pipeline

@ocofaigh ocofaigh merged commit 92b91b8 into main Apr 4, 2025
2 checks passed
@ocofaigh ocofaigh deleted the manual-bump branch April 4, 2025 16:05
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants