-
Notifications
You must be signed in to change notification settings - Fork 2
add: fully-configurable & security-enforced version #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@akocbek Since you are working on redis DA, do you want to review this to ensure we are consistent? |
ocofaigh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aditya-ranjan-16 You should delete the standard variation code since its replaced by the new variations. You also seem to be missing the updates to the ibm_catalog.json
|
@ocofaigh its still WIP raised this for internal discussion all of these are planed and will be included |
akocbek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for better maintenance we aim to have all ICD repos in sync. Please check and review Redis PR covering new DAs. We need to finalize the code that will be used across all ICD repos.
terraform-ibm-modules/terraform-ibm-icd-redis#580
you need to update the following files as well:
.catalog-onboard-pipeline.yamlfilecra-config.yamlfileibm_catalog.jsonfile- tests
- remove
standardDA
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
2 similar comments
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |


Description
https://github.ibm.com/GoldenEye/issues/issues/13008
Updates:
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
This PR creates new DA variations(fully-configurable & security-enforced) and deprecates the old Standard DA
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers