Skip to content

Conversation

@Aditya-ranjan-16
Copy link
Contributor

@Aditya-ranjan-16 Aditya-ranjan-16 commented Apr 22, 2025

Description

https://github.ibm.com/GoldenEye/issues/issues/13008

Updates:

  • added a new variable kms_encryption_enabled
  • referenced kms_encryption_enabled variable everywhere kms encryption is used
  • created 2 new DAs (fully-configurable and security-enforced)
  • removed previous DA
  • exposed local.prefix
  • support only existing resource group
  • added tests to test positive and negative scenarios for input variable
  • Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

This PR creates new DA variations(fully-configurable & security-enforced) and deprecates the old Standard DA

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@ocofaigh
Copy link
Contributor

@akocbek Since you are working on redis DA, do you want to review this to ensure we are consistent?

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aditya-ranjan-16 You should delete the standard variation code since its replaced by the new variations. You also seem to be missing the updates to the ibm_catalog.json

@ocofaigh ocofaigh requested a review from akocbek April 24, 2025 16:48
@Aditya-ranjan-16
Copy link
Contributor Author

@ocofaigh its still WIP raised this for internal discussion all of these are planed and will be included

Copy link
Contributor

@akocbek akocbek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for better maintenance we aim to have all ICD repos in sync. Please check and review Redis PR covering new DAs. We need to finalize the code that will be used across all ICD repos.
terraform-ibm-modules/terraform-ibm-icd-redis#580

you need to update the following files as well:

  • .catalog-onboard-pipeline.yaml file
  • cra-config.yaml file
  • ibm_catalog.json file
  • tests
  • remove standard DA

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

Screenshot 2025-05-06 at 4 22 24 AM Screenshot 2025-05-06 at 4 23 17 AM

Skipping Upgrade test as this PR deletes current standard DA and introduces new DA variations that are not present in current main branch yet

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16 Aditya-ranjan-16 marked this pull request as ready for review May 5, 2025 23:14
@Aditya-ranjan-16 Aditya-ranjan-16 changed the title add : fully-configurable & security-enforced version add: fully-configurable & security-enforced version May 6, 2025
@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

2 similar comments
@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16 Aditya-ranjan-16 requested a review from akocbek June 27, 2025 12:02
@akocbek
Copy link
Contributor

akocbek commented Jun 27, 2025

/run pipeline

@ocofaigh ocofaigh merged commit 7ae2a6e into main Jun 27, 2025
2 checks passed
@ocofaigh ocofaigh deleted the DA-13008 branch June 27, 2025 14:50
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants