fix: index error on kms key and backup key for encryption #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/run pipeline |
Contributor
Author
|
This is happening in the upgrade test, because the main branch is broken. The key-ring name created is icd-mysql, the referenced index is just icd. The upgrade will have to be skipped. TestRunUpgradeCompleteExample 2025-01-27T17:55:40Z command.go:185: ╷
TestRunUpgradeCompleteExample 2025-01-27T17:55:40Z command.go:185: │ Error: Invalid index
TestRunUpgradeCompleteExample 2025-01-27T17:55:40Z command.go:185: │
TestRunUpgradeCompleteExample 2025-01-27T17:55:40Z command.go:185: │ on main.tf line 115, in module "mysql_db":
TestRunUpgradeCompleteExample 2025-01-27T17:55:40Z command.go:185: │ 115: kms_key_crn = module.key_protect_all_inclusive.keys["icd.${var.prefix}-mysql"].crn
TestRunUpgradeCompleteExample 2025-01-27T17:55:40Z command.go:185: │ ├────────────────
TestRunUpgradeCompleteExample 2025-01-27T17:55:40Z command.go:185: │ │ module.key_protect_all_inclusive.keys is object with 2 attributes
TestRunUpgradeCompleteExample 2025-01-27T17:55:40Z command.go:185: │ │ var.prefix is "mysql-upg-lojce1"
TestRunUpgradeCompleteExample 2025-01-27T17:55:40Z command.go:185: │
TestRunUpgradeCompleteExample 2025-01-27T17:55:40Z command.go:185: │ The given key does not identify an element in this collection value. |
Contributor
Author
|
/run pipeline |
1 similar comment
Contributor
Author
|
/run pipeline |
toddgiguere
approved these changes
Jan 28, 2025
Contributor
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug fix. Keys need to referenced by
key-ring-name.key-name. The wrong key ring and key names were being used.This error may be on the main branch. IF it is, then the upgrade test will have to be skipped.
This is a test change, so no release will be required.
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers