Skip to content

Conversation

@shemau
Copy link
Contributor

@shemau shemau commented Apr 29, 2025

Description

The following variables are named inconsistently/incorrectly:

  • skip_mysql_sm_auth_policy
  • admin_pass_secret_manager_secret_group
  • use_existing_admin_pass_secret_manager_secret_group
  • admin_pass_secret_manager_secret_name

They are correctly renamed for Secrets Manager

  • skip_mysql_secrets_manager_auth_policy
  • admin_pass_secrets_manager_secret_group
  • use_existing_admin_pass_secrets_manager_secret_group
  • admin_pass_secrets_manager_secret_name

Is this a minor release, or a major release changing inputs in the DA?

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Inputs to the deployable architecture need updating. The following inputs are corrected, adding an s to make it secrets_manager.

  • skip_mysql_sm_auth_policy becomes skip_mysql_secrets_manager_auth_policy
  • admin_pass_secret_manager_secret_group becomes admin_pass_secrets_manager_secret_group
  • use_existing_admin_pass_secret_manager_secret_group becomes use_existing_admin_pass_secrets_manager_secret_group
  • admin_pass_secret_manager_secret_name becomes admin_pass_secrets_manager_secret_name

If the DA is being consumed as code, terraform inputs will need updating before plan and apply can be run.
If the DA is being consumed via projects/schematics the old value with have to be put in the new property in the UI.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@shemau
Copy link
Contributor Author

shemau commented Apr 29, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Apr 29, 2025

/run pipeline

@ocofaigh ocofaigh merged commit 9e7c9f4 into main May 1, 2025
2 checks passed
@ocofaigh ocofaigh deleted the da-inputs branch May 1, 2025 16:21
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants