Skip to content

Conversation

@shemau
Copy link
Contributor

@shemau shemau commented Jul 24, 2025

Description

Add support for two ICD features:

Deletion protection

This is feature flag, that when set to true provides protection from accidentally deleting the ICD instance.

Conceptually the instance is created with this flag set to true and if/when a destroy is attempted the request fails. In addition to requesting a destroy the flag must be set to false.

Note: This does not prevent the resource being destroyed outside of terraform.

In place major version upgrade

This feature allows the major version, whilst retaining the original instance connection endpoints. There is a service outage during this time, since the service will not accept database updates.

There is an feature flag, version_upgrade_skip_backup. It is NOT recommended to use this feature, since an upgrade failure may result in data loss. This flag avoids taking a backup whilst in read-only mode to speed the process up.

Full documentation at: https://cloud.ibm.com/docs/databases-for-mysql?topic=databases-for-mysql-mysql-upgrading&interface=ui

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@shemau
Copy link
Contributor Author

shemau commented Jul 24, 2025

/run pipeline

1 similar comment
@shemau
Copy link
Contributor Author

shemau commented Jul 24, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Jul 24, 2025

The pipeline failed twice with

TestRunUpgradeCompleteExample 2025-07-24T14:05:38Z logger.go:67: ╷
Error: UpgradeCompleteExample 2025-07-24T14:05:38Z logger.go:67: │ Error: [ERROR] Error creating resource key: The resource instance is not active with resp code: {
TestRunUpgradeCompleteExample 2025-07-24T14:05:38Z logger.go:67: │     "StatusCode": 422,

whilst locally it passed.

@shemau
Copy link
Contributor Author

shemau commented Jul 28, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Jul 31, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Aug 5, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Aug 7, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Aug 7, 2025

/run pipeline

@toddgiguere toddgiguere merged commit 716c24d into main Aug 7, 2025
2 checks passed
@toddgiguere toddgiguere deleted the major-upgrade branch August 7, 2025 18:14
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants