feat: Add UI regex-validation #349
Draft
+138
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run pipeline |
|
/run pipeline |
|
Tested the variables against different patterns, including null values, incorrect inputs, and correct inputs. Corresponding screenshots are attached below. 
- existing_secrets_manager_instance_crn 
- existing_kms_instance_crn 
- existing_kms_key_crn 
- backup crn 
- existing_backup_kms_key_crn 
|
shemau
requested changes
Nov 5, 2025
| { | ||
| "type": "regex", | ||
| "description": "The value provided for 'backup_crn' is not valid.", | ||
| "value": "^__NULL__$|^crn:.*:backup:" |
There was a problem hiding this comment.
Can this be improved? The CRN format is well defined, whilst the .* is vague. Can we at least make sure backup in the appropriate block. eg. (.*:){x}
| { | ||
| "type": "regex", | ||
| "description": "The value provided for 'backup_crn' is not valid.", | ||
| "value": "^__NULL__$|^crn:.*:backup:" |
There was a problem hiding this comment.
Can this be improved? The CRN format is well defined, whilst the .* is vague. Can we at least make sure backup in the appropriate block. eg. (.*:){x}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add UI regex valiadation in ibm_catalog.json.
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
This PR enables input validation in the UI for several string variables by leveraging the value_constraints array defined in the catalog. These constraints will be used by the UI to validate user input at runtime. The changed variables include:
prefix,existing_secrets_manager_instance_crn,existing_kms_instance_crn,existing_kms_key_crn,backup_crn,existing_backup_kms_key_crn,existing_mysql_instance_crn,remote_leader_crn.Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers