generated from terraform-ibm-modules/terraform-ibm-module-template
-
Notifications
You must be signed in to change notification settings - Fork 2
fix(deps): bump KMS with code change #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The expectation is that this PR will need to skip upgrade test because of the key ring force delete state change. The changes are in example code, not the main module, so no release is required. |
|
/run pipeline |
1 similar comment
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
TestRunStandardUpgradeSolution 2024-11-07T10:49:37Z command.go:185: # module.kms[0].module.kms_key_rings["postgresql-key-ring"].ibm_kms_key_rings.key_ring will be updated in-place
TestRunStandardUpgradeSolution 2024-11-07T10:49:37Z command.go:185: ~ resource "ibm_kms_key_rings" "key_ring" {
TestRunStandardUpgradeSolution 2024-11-07T10:49:37Z command.go:185: ~ force_delete = true -> false
TestRunStandardUpgradeSolution 2024-11-07T10:49:37Z command.go:185: id = "postgresql-key-ring:keyRing:crn:v1:bluemix:public:hs-crypto:us-south:a/abac0df06b644a9cabc6e44f55b3880e:e6dce284-e80f-46e1-a3c1-830f7adff7a9::"
TestRunStandardUpgradeSolution 2024-11-07T10:49:37Z command.go:185: # (3 unchanged attributes hidden)
TestRunStandardUpgradeSolution 2024-11-07T10:49:37Z command.go:185: }This was the only error, so skipping update test. |
|
/run pipeline |
ocofaigh
approved these changes
Nov 7, 2024
|
🎉 This PR is included in version 3.17.12 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update KMS all inclusive which removes key ring force delete because it is deprecated by the provider
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers