Skip to content

Conversation

@ocofaigh
Copy link
Contributor

@ocofaigh ocofaigh commented Nov 11, 2024

Description

  • Expose the ability to use default encryption keys in fscloud submodule + DA
  • Exposed the ability to set the IBM provider visibility (defaults to private)

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Contributor Author

Need to skip the upgrade test due to new variable being added, and the fact that it has to be set to public for upgrade test to work in GHA runtime..

│ Error: Value for undeclared variable
│ 
│ A variable named "provider_visibility" was assigned on the command line,
│ but the root module does not declare a variable of that name. To use this
│ value, add a "variable" block to the configuration.
╵}

@ocofaigh
Copy link
Contributor Author

/run pipeline

@rajatagarwal-ibm
Copy link
Member

/run pipeline

@ocofaigh ocofaigh merged commit ed78199 into main Nov 12, 2024
2 checks passed
@ocofaigh ocofaigh deleted the keys branch November 12, 2024 10:57
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants