Skip to content

Conversation

@ocofaigh
Copy link
Contributor

@ocofaigh ocofaigh commented Nov 12, 2024

Description

  • fix bug when setting use_ibm_owned_encryption_key to true in the DA
  • fixed the use_ibm_owned_encryption_key so its a boolean (was incorrectly set as string)

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@ocofaigh ocofaigh changed the title fix: corrected the var type in DA fix bug when setting use_ibm_owned_encryption_key to true in the DA Nov 12, 2024
@ocofaigh
Copy link
Contributor Author

/run pipeline

1 similar comment
@ocofaigh
Copy link
Contributor Author

/run pipeline

@jor2 jor2 self-requested a review November 12, 2024 18:31
@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh ocofaigh merged commit 857e1fd into main Nov 12, 2024
2 checks passed
@ocofaigh ocofaigh deleted the ocofaigh-patch-2 branch November 12, 2024 21:00
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.19.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants