Skip to content

Conversation

@jor2
Copy link
Member

@jor2 jor2 commented Jan 8, 2025

Description

update supported versions for postgres

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

update supported versions for postgres

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@jor2 jor2 self-assigned this Jan 8, 2025
@jor2
Copy link
Member Author

jor2 commented Jan 8, 2025

/run pipeline

Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be tests pinned to version, at least a couple in other_test.go.

@jor2
Copy link
Member Author

jor2 commented Jan 9, 2025

There should be tests pinned to version, at least a couple in other_test.go.

I was thinking about that, but it seems v17 is still in beta and v16 is preferred. Thoughts?

Screenshot 2025-01-09 at 13 35 23

@jor2
Copy link
Member Author

jor2 commented Jan 9, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Jan 9, 2025

There should be tests pinned to version, at least a couple in other_test.go.

I was thinking about that, but it seems v17 is still in beta and v16 is preferred. Thoughts?

Screenshot 2025-01-09 at 13 35 23

Never-mind, updated other_test.go

@jor2
Copy link
Member Author

jor2 commented Jan 9, 2025

/run pipeline

@jor2 jor2 requested a review from shemau January 9, 2025 13:40
Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toddgiguere toddgiguere merged commit 1739da7 into main Jan 9, 2025
2 checks passed
@toddgiguere toddgiguere deleted the version-deprecation branch January 9, 2025 18:45
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.20.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants