- 
                Notifications
    
You must be signed in to change notification settings  - Fork 2
 
fix: bug with password #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           /run pipeline  | 
    
| 
           /run pipeline  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to include common-dev-assets. Maybe that should be removed.
| 
           I believe this failure can be attributed to the update in common-dev-assets adding a new pre-commit hook that now validates the ibm_catalog.json against the DA. This probably did not previously run and now when it runs it fails. The expectation is that there might be a few of these as the new pre-commit hook gets rolled out.  | 
    
| 
           Right, not sure why common-dev-assets was updated in this PR? Renovate will create a PR over the weekend (which will fail). Suggest to remove common-dev-assets from this PR and we can handle bumping it in a separate effort  | 
    
| 
           /run pipeline  | 
    
| 
           /run pipeline  | 
    
| 
           🎉 This PR is included in version 3.20.8 🎉 The release is available on: 
 Your semantic-release bot 📦🚀  | 
    
Description
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers