- 
                Notifications
    
You must be signed in to change notification settings  - Fork 2
 
fix: bug with crn parser #571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           /run pipeline  | 
    
| 
           /run pipeline  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There must be a bug somewhere, as the new test is failing with:
TestPlanValidation 2025-01-23T11:38:00Z logger.go:67: Running command terraform with args [plan -input=false -lock=false -var admin_pass=A1BNTnGYSGZVaWR -var use_ibm_owned_encryption_key=false -var prefix=validate-plan -var existing_kms_instance_crn=crn:v1:bluemix:public:hs-crypto:us-south:a/abac0df06b644a9cabc6e44f55b3880e:e6dce284-e80f-46e1-a3c1-830f7adff7a9:: -var kms_endpoint_type=public -var provider_visibility=public -var resource_group_name=validate-plan -var region=us-south -var use_default_backup_encryption_key=true -lock=false]
TestPlanValidation 2025-01-23T11:38:00Z retry.go:99: Returning due to fatal error: FatalError{Underlying: error while running command: chdir solutions/standard: no such file or directory; }
Can you also update the new test to test the config we test in TestRunStandardSolutionIBMKeys and then remove that test? Suggest to use a for loop over the logic to test the different configs
| 
           /run pipeline  | 
    
| 
           /run pipeline  | 
    
| 
           completes in 14s.  | 
    
| 
           /run pipeline  | 
    
| 
           🎉 This PR is included in version 3.20.9 🎉 The release is available on: 
 Your semantic-release bot 📦🚀  | 
    
Description
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers