feat: expose remote_leader_crn in fscloud module and DA #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewLemmond
requested review from
Ak-sky and
rajatagarwal-ibm
as code owners
|
/run pipeline |
ocofaigh
reviewed
Jan 24, 2025
|
|
||
| variable "remote_leader_crn" { | ||
| type = string | ||
| description = "A CRN of the leader database to make the replica(read-only) deployment. The leader database is created by a database deployment with the same service ID. A read-only replica is set up to replicate all of your data from the leader deployment to the replica deployment by using asynchronous replication. [Learn more](https://cloud.ibm.com/docs/databases-for-postgresql?topic=databases-for-postgresql-read-only-replicas)." |
There was a problem hiding this comment.
@MatthewLemmond FYI i pushed a commit to update the description of the DA variable. Instead of adding a long url to the description, which will look horrible in projects UI, use a markdown link as that will render in projects UI.
|
/run pipeline |
|
🎉 This PR is included in version 3.21.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expose the ability to create read-only replicas in the FS Cloud submodule and the DA
resolves #569
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
expose the
remote_leader_crnvariable in FS Cloud submodule and Deployable ArchitectureRun the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers