Update prefix value in DA

[arya-girish-k]

Description

Update the prefix value as dev in DA.

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[arya-girish-k]

/run pipeline

[arya-girish-k]

Plan output for reference:
if providing prefix value as dev

resource_group_name  = "dev-aryrg"
postgres_key_name   = "dev-postgresql-key"
postgres_key_ring_name = "dev-postgresql-key-ring"
postgresql_db_name  = "dev-postgresql"

if providing prefix value as null or empty string :

resource_group_name  = "aryrg"
postgres_key_name   = "postgresql-key"
postgres_key_ring_name = "postgresql-key-ring"
postgresql_db_name  = "postgresql"

[shemau]

LGTM

This is consistent with elasticsearch

[shemau]

@ocofaigh this is listed as no release, but that is wrong. A release is required because this changes source code in the DA. That noted, this could potential cause existing DA deployments to delete and recreate the persistent storage (postgresql instance). The use case is any schematics/projects that is deployed using the default value, will see the default value change which will change (many) resource names, including the postgresql instance name.

[shemau]

/run pipeline

[arya-girish-k]

Encountering a similar error on PRs for the ICD databases
Error: │ Error: [ERROR] Error waiting for create database instance (crn:v1:bluemix:public:databases-for-postgresql:us-south:a/abac0df06b644a9cabc6e44f55b3880e:ede68456-94b2-4cce-b877-a7a112da59b8::) to complete: [ERROR] Error ICD interface not ready after create: crn:v1:bluemix:public:databases-for-postgresql:us-south:a/abac0df06b644a9cabc6e44f55b3880e:ede68456-94b2-4cce-b877-a7a112da59b8:: with error [ERROR] Error getting database config for: crn:v1:bluemix:public:databases-for-postgresql:us-south:a%2Fabac0df06b644a9cabc6e44f55b3880e:ede68456-94b2-4cce-b877-a7a112da59b8:: with error Request failed with status code: 500, ServerErrorResponse: {"status":500,"error":"Internal Server Error"}

I have noticed @shemau has already raised support ticket similar to this issue-https://cloud.ibm.com/unifiedsupport/cases/manage/CS4228375?accountId=abac0df06b644a9cabc6e44f55b3880e for the same.Waiting for the issue is being resolved, till then paused working on this PR.

[shemau]

/run pipeline

[shemau]

/run pipeline

[shemau]

There are lots of changes in the upgrade DA test:

        	            	Address: module.postgresql_db.module.postgresql_db.ibm_database.postgresql_db
        	            	Actions: [update]
        	            	DIFF:
        	            	  Before: 
        	            		{"name":"postgresql-postgresql"}
        	            	  After: 
        	            		{"name":"dev-postgresql"}

So the DB looks like an upgrade in place, but many other resources are being delete due the change in prefix.

Can we have a review of what is changing and a write up for the release notes section of the description.

[ocofaigh]

I can handle the release notes - but we will need to skip upgrade test to get this pipeline to pass

[arya-girish-k]

/run pipeline

[terraform-ibm-modules-ops]

🎉 This PR is included in version 3.21.2 🎉

The release is available on:

• GitHub release
• v3.21.2

Your semantic-release bot 📦🚀