Skip to content

Conversation

@aatreyee2506
Copy link
Contributor

@aatreyee2506 aatreyee2506 commented Mar 12, 2025

Description

Added tests and missing examples to make Postgresql consistent.
Git issue

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Issues Addressed:
1.Added TestRunExistingInstance .
2.Removed TestRunFSCloudExample and TestRunBasicExample
3.Added existing_postgresql_instance_crn variable in the DA.
4.cbr_rules have been extended, added tags and operations.
5. Changed the resource_tags to tags in variables.tf of root module.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@aatreyee2506
Copy link
Contributor Author

/run pipeline

@aatreyee2506 aatreyee2506 changed the title Test coverage Test coverage : Postgresql Mar 17, 2025
@aatreyee2506
Copy link
Contributor Author

/run pipeline

@aatreyee2506 aatreyee2506 marked this pull request as ready for review March 17, 2025 09:55
Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shemau
Copy link
Contributor

shemau commented Mar 18, 2025

I have approved this, but the description is light on detail. resource_tags has been changed to tags, so code may have to be changed. cbr_rules has been extended, existing_postgresql_instance_crn is only in the DA.

@maheshwarishikha maheshwarishikha merged commit 791d46d into main Mar 20, 2025
2 checks passed
@maheshwarishikha maheshwarishikha deleted the test-coverage branch March 20, 2025 05:13
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants