Skip to content

Conversation

@rajatagarwal-ibm
Copy link
Member

Description

Fixed tests and updated examples

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@rajatagarwal-ibm rajatagarwal-ibm requested a review from Ak-sky as a code owner July 1, 2025 09:24
@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

whoffler
whoffler previously approved these changes Jul 1, 2025
Copy link
Contributor

@whoffler whoffler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where/when do other_tests run? They on a weekly build somewhere?

@rajatagarwal-ibm
Copy link
Member Author

@whoffler, they run weekly. There is a tekton pipeline set up for continuous tests in Ops account, which runs both pr_tests and other_tests on a weekly basis. Code owners get notifications if they fail.

@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocofaigh ocofaigh merged commit c098325 into main Jul 2, 2025
2 checks passed
@ocofaigh ocofaigh deleted the pg-version-fix branch July 2, 2025 10:40
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 4.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants