chore: add config_constraints to code_editor variables in ibm_catalog.json#761
chore: add config_constraints to code_editor variables in ibm_catalog.json#761
Conversation
|
This PR adds |
shemau
left a comment
There was a problem hiding this comment.
This PR should bump common-dev-assets. IMHO this is the best way to make sure that enhanced validations completed in PR hooks updated by common-dev-assets.
Validate ibm_catalog.json file............................................Failed
- hook id: validate_ibm_catalog_json
- exit code: 1
product_label: 'Cloud automation for Databases for PostgreSQL'
flavor_label: 'Fully configurable'
working_directory: 'solutions/fully-configurable':
- key 'flavors.short_description' is missing
- the following inputs should have HCL editor in ibm_catalog.json: ['service_credential_names', 'service_credential_secrets', 'users']
******* HCL editor syntax is: *******
"custom_config": {
"type": "code_editor",
"grouping": "deployment",
"original_grouping": "deployment",
"config_constraints": {
"supportedLanguages": ["hcl"]
}
}
product_label: 'Cloud automation for Databases for PostgreSQL'
flavor_label: 'Security-enforced'
working_directory: 'solutions/security-enforced':
- key 'flavors.short_description' is missing
- the following inputs should have HCL editor in ibm_catalog.json: ['service_credential_names', 'service_credential_secrets', 'users']
******* HCL editor syntax is: *******
"custom_config": {
"type": "code_editor",
"grouping": "deployment",
"original_grouping": "deployment",
"config_constraints": {
"supportedLanguages": ["hcl"]
}
}
Making all the catalog json updates in 1 PR saves running hundreds of not thousands of service instance provisions.
|
@shemau updated the PR, can you pls review. Thanks. |
|
/run pipeline |
|
/run pipeline |
1 similar comment
|
/run pipeline |
shemau
left a comment
There was a problem hiding this comment.
Bumping to the latest common-dev-assets resolved pipeline issue.
|
🎉 This PR is included in version 4.4.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
No description provided.