Skip to content

Conversation

@piyush117
Copy link
Contributor

No description provided.

@piyush117
Copy link
Contributor Author

This PR adds config_constraints with supportedLanguages: ["hcl"] to all variables in ibm_catalog.json that have code_editor type in their custom_config. This enables HCL syntax highlighting for code editor fields in the IBM Cloud catalog.

Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should bump common-dev-assets. IMHO this is the best way to make sure that enhanced validations completed in PR hooks updated by common-dev-assets.

Validate ibm_catalog.json file............................................Failed
- hook id: validate_ibm_catalog_json
- exit code: 1

product_label: 'Cloud automation for Databases for PostgreSQL'
flavor_label: 'Fully configurable'
working_directory: 'solutions/fully-configurable':

- key 'flavors.short_description' is missing
- the following inputs should have HCL editor in ibm_catalog.json: ['service_credential_names', 'service_credential_secrets', 'users']

******* HCL editor syntax is: *******

"custom_config": {
  "type": "code_editor",
  "grouping": "deployment",
  "original_grouping": "deployment",
  "config_constraints": {
    "supportedLanguages": ["hcl"]
  }
}

product_label: 'Cloud automation for Databases for PostgreSQL'
flavor_label: 'Security-enforced'
working_directory: 'solutions/security-enforced':

- key 'flavors.short_description' is missing
- the following inputs should have HCL editor in ibm_catalog.json: ['service_credential_names', 'service_credential_secrets', 'users']

******* HCL editor syntax is: *******

"custom_config": {
  "type": "code_editor",
  "grouping": "deployment",
  "original_grouping": "deployment",
  "config_constraints": {
    "supportedLanguages": ["hcl"]
  }
}

Making all the catalog json updates in 1 PR saves running hundreds of not thousands of service instance provisions.

@piyush117
Copy link
Contributor Author

@shemau updated the PR, can you pls review. Thanks.

@piyush117
Copy link
Contributor Author

/run pipeline

@shemau
Copy link
Contributor

shemau commented Dec 12, 2025

/run pipeline

1 similar comment
@shemau
Copy link
Contributor

shemau commented Dec 12, 2025

/run pipeline

Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping to the latest common-dev-assets resolved pipeline issue.

@ocofaigh ocofaigh merged commit fcb024a into main Dec 12, 2025
2 checks passed
@ocofaigh ocofaigh deleted the add_code_editor_config_constraints branch December 12, 2025 16:01
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 4.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants