fix: bug with crn parser #571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run pipeline |
|
/run pipeline |
ocofaigh
requested changes
Jan 23, 2025
There was a problem hiding this comment.
There must be a bug somewhere, as the new test is failing with:
TestPlanValidation 2025-01-23T11:38:00Z logger.go:67: Running command terraform with args [plan -input=false -lock=false -var admin_pass=A1BNTnGYSGZVaWR -var use_ibm_owned_encryption_key=false -var prefix=validate-plan -var existing_kms_instance_crn=crn:v1:bluemix:public:hs-crypto:us-south:a/abac0df06b644a9cabc6e44f55b3880e:e6dce284-e80f-46e1-a3c1-830f7adff7a9:: -var kms_endpoint_type=public -var provider_visibility=public -var resource_group_name=validate-plan -var region=us-south -var use_default_backup_encryption_key=true -lock=false]
TestPlanValidation 2025-01-23T11:38:00Z retry.go:99: Returning due to fatal error: FatalError{Underlying: error while running command: chdir solutions/standard: no such file or directory; }
Can you also update the new test to test the config we test in TestRunStandardSolutionIBMKeys and then remove that test? Suggest to use a for loop over the logic to test the different configs
|
/run pipeline |
|
/run pipeline |
jor2
changed the title
|
completes in 14s. |
|
/run pipeline |
ocofaigh
changed the title
ocofaigh
approved these changes
Jan 23, 2025
|
🎉 This PR is included in version 3.20.9 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers