From 61f3254f1c61950c8eeb55acedd8fd04ab267188 Mon Sep 17 00:00:00 2001 From: piyush Date: Wed, 3 Sep 2025 11:55:46 +0530 Subject: [PATCH 1/3] chore: Fix regex validation to enforce exact match (public or private) --- solutions/fully-configurable/variables.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/solutions/fully-configurable/variables.tf b/solutions/fully-configurable/variables.tf index 828a8731..fd6c0091 100644 --- a/solutions/fully-configurable/variables.tf +++ b/solutions/fully-configurable/variables.tf @@ -263,7 +263,7 @@ variable "kms_endpoint_type" { default = "private" validation { - condition = can(regex("public|private", var.kms_endpoint_type)) + condition = can(regex("^(public|private)$", var.kms_endpoint_type)) error_message = "The kms_endpoint_type value must be 'public' or 'private'." } } From 69460f509d029cea2d2570e9344ee95c5c8411d0 Mon Sep 17 00:00:00 2001 From: Piyush Kumar Sahu Date: Thu, 4 Sep 2025 11:54:44 +0530 Subject: [PATCH 2/3] Addressed the feedback --- solutions/fully-configurable/variables.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/solutions/fully-configurable/variables.tf b/solutions/fully-configurable/variables.tf index fd6c0091..1586bcb7 100644 --- a/solutions/fully-configurable/variables.tf +++ b/solutions/fully-configurable/variables.tf @@ -86,7 +86,7 @@ variable "service_endpoints" { default = "private" validation { - condition = can(regex("public|public-and-private|private", var.service_endpoints)) + condition = can(regex("^(public|public-and-private|private)$", var.service_endpoints)) error_message = "Valid values for service_endpoints are 'public', 'public-and-private', and 'private'" } } From 1e2b25968cb67e5619d5bae5f64ea0e00c12cc2e Mon Sep 17 00:00:00 2001 From: Piyush Kumar Sahu Date: Thu, 4 Sep 2025 12:01:53 +0530 Subject: [PATCH 3/3] Addressed the feedback #2 --- examples/basic/variables.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/basic/variables.tf b/examples/basic/variables.tf index 9dadb5c2..1fdd13af 100644 --- a/examples/basic/variables.tf +++ b/examples/basic/variables.tf @@ -46,7 +46,7 @@ variable "service_endpoints" { default = "public" validation { - condition = can(regex("public|public-and-private|private", var.service_endpoints)) + condition = can(regex("^(public|public-and-private|private)$", var.service_endpoints)) error_message = "Valid values for service_endpoints are 'public', 'public-and-private', and 'private'" } }