Skip to content

Commit 0c09bef

Browse files
authored
fix: removed tag from ibm_resource_key block - tagging resource keys is not supported by IBM Cloud so no impact to any actual resources here (#7)
1 parent b38e950 commit 0c09bef

File tree

4 files changed

+6
-9
lines changed

4 files changed

+6
-9
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ You need the following permissions to run this module.
8989
| <a name="input_resource_group_id"></a> [resource\_group\_id](#input\_resource\_group\_id) | The resource group ID where the RabbitMQ instance will be created. | `string` | n/a | yes |
9090
| <a name="input_service_credential_names"></a> [service\_credential\_names](#input\_service\_credential\_names) | Map of name, role for service credentials that you want to create for the database | `map(string)` | `{}` | no |
9191
| <a name="input_skip_iam_authorization_policy"></a> [skip\_iam\_authorization\_policy](#input\_skip\_iam\_authorization\_policy) | Set to true to skip the creation of an IAM authorization policy that permits all RabbitMQ instances in the given resource group to read the encryption key from the Hyper Protect or Key Protect instance passed in var.existing\_kms\_instance\_guid. If set to 'false', a value must be passed for var.existing\_kms\_instance\_guid. No policy is created if var.kms\_encryption\_enabled is set to 'false'. | `bool` | `false` | no |
92-
| <a name="input_tags"></a> [tags](#input\_tags) | (Optional, Array of Strings) A list of tags that you want to add to your instance. | `list(any)` | `[]` | no |
92+
| <a name="input_tags"></a> [tags](#input\_tags) | Optional list of tags to be added to the RabbitMQ instance. | `list(any)` | `[]` | no |
9393
| <a name="input_users"></a> [users](#input\_users) | A list of users that you want to create on the database. Multiple blocks are allowed. The user password must be in the range of 10-32 characters. Be warned that in most case using IAM service credentials (via the var.service\_credential\_names) is sufficient to control access to the RabbitMQ instance. This blocks creates native RabbitMQ database users, more info on that can be found here https://cloud.ibm.com/docs/messages-for-rabbitmq?topic=messages-for-rabbitmq-user-management | <pre>list(object({<br> name = string<br> password = string # pragma: allowlist secret<br> type = string # "type" is required to generate the connection string for the outputs.<br> role = optional(string)<br> }))</pre> | `[]` | no |
9494

9595
### Outputs

main.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,6 @@ resource "ibm_resource_key" "service_credentials" {
172172
name = each.key
173173
role = each.value
174174
resource_instance_id = ibm_database.rabbitmq_database.id
175-
tags = var.tags
176175
}
177176

178177
locals {

module-metadata.json

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -283,11 +283,10 @@
283283
"tags": {
284284
"name": "tags",
285285
"type": "list(any)",
286-
"description": "(Optional, Array of Strings) A list of tags that you want to add to your instance.",
286+
"description": "Optional list of tags to be added to the RabbitMQ instance.",
287287
"default": [],
288288
"source": [
289-
"ibm_database.rabbitmq_database.tags",
290-
"ibm_resource_key.service_credentials.tags"
289+
"ibm_database.rabbitmq_database.tags"
291290
],
292291
"pos": {
293292
"filename": "variables.tf",
@@ -454,8 +453,7 @@
454453
"type": "ibm_resource_key",
455454
"name": "service_credentials",
456455
"attributes": {
457-
"for_each": "service_credential_names",
458-
"tags": "tags"
456+
"for_each": "service_credential_names"
459457
},
460458
"provider": {
461459
"name": "ibm"
@@ -498,7 +496,7 @@
498496
},
499497
"pos": {
500498
"filename": "main.tf",
501-
"line": 199
499+
"line": 198
502500
}
503501
}
504502
},

variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ variable "instance_name" {
2020

2121
variable "tags" {
2222
type = list(any)
23-
description = "(Optional, Array of Strings) A list of tags that you want to add to your instance."
23+
description = "Optional list of tags to be added to the RabbitMQ instance."
2424
default = []
2525
}
2626

0 commit comments

Comments
 (0)