Skip to content

Commit 9a3aaf0

Browse files
piyush117shemau
andauthored
fix: variable validation fix (#443)
* chore: Fix regex validation to enforce exact match (public or private) * Addressed the feedback --------- Co-authored-by: shemau <[email protected]>
1 parent 6623884 commit 9a3aaf0

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

examples/basic/variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ variable "service_endpoints" {
4646
default = "public"
4747

4848
validation {
49-
condition = can(regex("public|public-and-private|private", var.service_endpoints))
49+
condition = can(regex("^(public|public-and-private|private)$", var.service_endpoints))
5050
error_message = "Valid values for service_endpoints are 'public', 'public-and-private', and 'private'"
5151
}
5252
}

solutions/fully-configurable/variables.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ variable "service_endpoints" {
8080
default = "private"
8181

8282
validation {
83-
condition = can(regex("public|public-and-private|private", var.service_endpoints))
83+
condition = can(regex("^(public|public-and-private|private)$", var.service_endpoints))
8484
error_message = "Valid values for service_endpoints are 'public', 'public-and-private', and 'private'"
8585
}
8686
}
@@ -218,7 +218,7 @@ variable "kms_endpoint_type" {
218218
default = "private"
219219

220220
validation {
221-
condition = can(regex("public|private", var.kms_endpoint_type))
221+
condition = can(regex("^(public|private)$", var.kms_endpoint_type))
222222
error_message = "The kms_endpoint_type value must be 'public' or 'private'."
223223
}
224224
}

variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ variable "service_endpoints" {
121121
default = "private"
122122

123123
validation {
124-
condition = can(regex("public|public-and-private|private", var.service_endpoints))
124+
condition = can(regex("^(public|public-and-private|private)$", var.service_endpoints))
125125
error_message = "Valid values for service_endpoints are 'public', 'public-and-private', and 'private'"
126126
}
127127
}

0 commit comments

Comments
 (0)