Skip to content

Conversation

@jor2
Copy link
Member

@jor2 jor2 commented Nov 7, 2024

Description

We got the following failure in continuous tests

TestPlanICDVersions/3.13 2024-10-24T05:10:42Z retry.go:99: Returning due to fatal error: FatalError{Underlying: error while running command: exit status 1; ╷
│ Error: Invalid value for variable
│ 
│   on [main.tf](http://main.tf/) line 24, in module "icd_rabbitmq":24:   rabbitmq_version  = var.rabbitmq_version
│     ├────────────────
│     │ var.rabbitmq_version is "3.13"
│ 
│ Version must be 3.11 or 3.12. If no value passed, the current ICD preferred
│ version is used.
│ 
│ This was checked by the validation rule at ../../variables.tf:20,3-13.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Support the latest rabbitmq version 3.13. Remove lowerbound version 3.11.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@jor2 jor2 self-assigned this Nov 7, 2024
@jor2 jor2 requested review from iamar7 and shemau as code owners November 7, 2024 11:52
@jor2
Copy link
Member Author

jor2 commented Nov 7, 2024

/run pipeline

Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ocofaigh ocofaigh merged commit d8f0953 into main Nov 7, 2024
2 checks passed
@ocofaigh ocofaigh deleted the update-version branch November 7, 2024 12:23
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants