Skip to content

Conversation

@jor2
Copy link
Member

@jor2 jor2 commented Jan 15, 2025

Description

added a solutions folder and refactored kms logic.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Features

  • Root module updates:
    • existing_kms_instance_guid is no longer a supported input. The code will now parse the GUID from the KMS key CRN
    • added new input use_same_kms_key_for_backups to give more control over KMS key usage
    • kms_encryption_enabled has been renamed to use_ibm_owned_encryption_key
  • fscloud submodule updates:
    • added new inputs use_default_backup_encryption_key and use_same_kms_key_for_backups

⚠️ Please note that when updating to this version, the s2s KMS auth policy that is created is now scoped to the exact KMS key, so you will see a destroy and re-create of the auth policy. The new policy will be created before the old one is deleted, so there will be no disruption to every day operations.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@jor2 jor2 self-assigned this Jan 15, 2025
@jor2 jor2 requested review from iamar7 and shemau as code owners January 15, 2025 22:44
@jor2
Copy link
Member Author

jor2 commented Jan 15, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Jan 15, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Jan 16, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Jan 16, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Jan 16, 2025

/run pipeline

@ocofaigh ocofaigh merged commit 55f2bf0 into main Jan 16, 2025
2 checks passed
@ocofaigh ocofaigh deleted the refactor-kms branch January 16, 2025 11:31
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants