-
Notifications
You must be signed in to change notification settings - Fork 1
fix: bug with password #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…-icd-rabbitmq into refactor-kms
|
/run pipeline |
shemau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new DA (added this week) and has a TestRunStandardUpgradeSolution test, which should be updated to pass adminpass: like the others.
ocofaigh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the DA tests needs to be updated to test the use case of passing admin_pass. Looks like there are two upgrade tests. you only need 1 (on the DA), so please remove TestRunCompleteUpgradeExample
|
/run pipeline |
|
🎉 This PR is included in version 1.13.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers