Skip to content

Conversation

@jor2
Copy link
Member

@jor2 jor2 commented Jan 17, 2025

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@jor2 jor2 self-assigned this Jan 17, 2025
@jor2 jor2 requested review from iamar7 and shemau as code owners January 17, 2025 13:37
@jor2
Copy link
Member Author

jor2 commented Jan 17, 2025

/run pipeline

shemau
shemau previously requested changes Jan 17, 2025
Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new DA (added this week) and has a TestRunStandardUpgradeSolution test, which should be updated to pass adminpass: like the others.

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the DA tests needs to be updated to test the use case of passing admin_pass. Looks like there are two upgrade tests. you only need 1 (on the DA), so please remove TestRunCompleteUpgradeExample

@jor2
Copy link
Member Author

jor2 commented Jan 18, 2025

/run pipeline

@ocofaigh ocofaigh dismissed shemau’s stale review January 20, 2025 10:14

change implemented

@ocofaigh ocofaigh merged commit 716874c into main Jan 20, 2025
2 checks passed
@ocofaigh ocofaigh deleted the fix-pass-issue branch January 20, 2025 10:14
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.13.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants