-
Notifications
You must be signed in to change notification settings - Fork 1
feat: support for configuration #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
|
Nearing completion. One final pass and tidy up before being ready for review. |
|
The upgrade test, failed showing Which is the new option being added and flagged update in place. |
|
This is definitely just showing an update in place. So I am going to skip upgrade test. |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should configuration be using the new HCL editor in ibm_catalog.json? I'm not sure what it defaults to now if no widget is defined, but I think it might try to do json validation. Probably worth importing this branch into a catalog and checking.
|
/run pipeline |
This reverts commit ef2a304.
|
/run pipeline |
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
#311
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Add support for passing a configuration block when creating the ICD instance. This includes base module, fscloud sub module and deployable architecture.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers