-
Notifications
You must be signed in to change notification settings - Fork 1
fix: drop 3.12 support, add 4.0 support #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
|
Note: This PR passes as-is, but will break CI pipelines until the common-dev-assets has 3.13 or higher database AND that database has backups to restore from. The current common-dev-assets is 3.12, the new 3.13 DB does not have backups yet. This PR can be merged and resolve the CI issues after renovate, or it can be merged after renovate when it can be demonstrated locally that TestRunRestoredDBExample passes. |
|
/run pipeline |
tests/other_test.go
Outdated
| "github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper/testhelper" | ||
| ) | ||
|
|
||
| func TestRunCompleteUpgradeExample(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrade test will never run in tests/other_test.go so its pointless in adding it. If we have a DA upgrade test, we don't need an example one too. Just make sure there is a standard test for the example (in pr_test.go or other_test.go)
|
/run pipeline |
|
🎉 This PR is included in version 1.18.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Remove validation for versions of messages for rabbitmq that are no longer supported by the service and adding support for version 4.0 that is in preview.
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Remove support for rabbitmq version 3.12, the service has reached end of life.
Add support for rabbitmq version 4.0, the service is available in preview.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers