Skip to content

Conversation

@shemau
Copy link
Contributor

@shemau shemau commented May 23, 2025

Description

Remove validation for versions of messages for rabbitmq that are no longer supported by the service and adding support for version 4.0 that is in preview.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Remove support for rabbitmq version 3.12, the service has reached end of life.
Add support for rabbitmq version 4.0, the service is available in preview.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@shemau shemau requested a review from iamar7 as a code owner May 23, 2025 15:02
@shemau
Copy link
Contributor Author

shemau commented May 23, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented May 23, 2025

Note: This PR passes as-is, but will break CI pipelines until the common-dev-assets has 3.13 or higher database AND that database has backups to restore from.

The current common-dev-assets is 3.12, the new 3.13 DB does not have backups yet.

This PR can be merged and resolve the CI issues after renovate, or it can be merged after renovate when it can be demonstrated locally that TestRunRestoredDBExample passes.

@shemau
Copy link
Contributor Author

shemau commented May 26, 2025

/run pipeline

iamar7
iamar7 previously approved these changes May 30, 2025
"github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper/testhelper"
)

func TestRunCompleteUpgradeExample(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade test will never run in tests/other_test.go so its pointless in adding it. If we have a DA upgrade test, we don't need an example one too. Just make sure there is a standard test for the example (in pr_test.go or other_test.go)

@shemau
Copy link
Contributor Author

shemau commented May 30, 2025

/run pipeline

@ocofaigh ocofaigh merged commit 440ec44 into main May 30, 2025
2 checks passed
@ocofaigh ocofaigh deleted the versions branch May 30, 2025 15:57
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants