Skip to content

Conversation

@whoffler
Copy link
Contributor

@whoffler whoffler commented Jul 22, 2025

Description

for issue - https://github.ibm.com/GoldenEye/issues/issues/14658

use WithNewResourceGroup context manager so tests avoid resource collision

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@whoffler whoffler requested review from iamar7 and shemau as code owners July 22, 2025 09:17
Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whoffler whoffler force-pushed the createResourceGroupForTest branch from 9acef1a to 4440a3a Compare July 22, 2025 12:52
@whoffler
Copy link
Contributor Author

/run pipeline

@maheshwarishikha maheshwarishikha merged commit 05c00ca into main Jul 23, 2025
2 checks passed
@maheshwarishikha maheshwarishikha deleted the createResourceGroupForTest branch July 23, 2025 07:57
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.0.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants