Configurable app-check for elasticsearch

[kevtimov247]

Description

As an operator I would like to be able to configure the sysdig monitoring agent to monitor specific apps using the app-checks option.
For this the configmap-template should be adjusted, similar to this:

app_checks:
- name: {{ .Values.app_check_name }}
check_module: elastic
pattern:
port: {{ .Values.app_check_port }}
comm: {{ .Values.app_check_comm }}
conf:
url: {{ .Values.app_check_url }}:{{ .Values.app_check_port }}
ssl_verify: {{ .Values.ssl_verify }}
{{if .Values.username}}
username: {{ .Values.username }}
{{end}}
{{if .Values.password}}
password: {{ .Values.password }}
{{end}}
{{- end -}}

Eventually more app-checks can be added according to:
https://docs.sysdig.com/en/docs/sysdig-monitor/integrations/legacy-integrations/legacyintegrate-applications-default-app-checks/

New or affected modules

[https://github.com/terraform-ibm-modules/terraform-ibm-observability-agents/blob/main/chart/sysdig-agent/templates/configmap.yaml]

[ocofaigh]

Cloud Monitoring agent module is moving to this repo: https://github.com/terraform-ibm-modules/terraform-ibm-monitoring-agent
So this change will likely go directly into that new module once the migration PR is merged

[Aditya-ranjan-16]

@kevtimov247 App checks seems to be deprecated by the sys dig team in favor of Monitoring Integrations. do we still want to implement this ?

[kevtimov247]

Not needed. Indeed there are now other ways to exclude applications from monitoring. They are fully supported by the terraform-ibm-modules/monitoring-agent/ibm, for example container-filter or port blacklisting.

[Aditya-ranjan-16]

No longer needed , Closing the issue