Skip to content

Commit 276e463

Browse files
imprateekshimprateeksh
authored
fix: The network_connections option has been removed from the network_acls variable as it was not being used in the code (#488)
BREAKING CHANGE: If you are upgrading to this version, and you have the `network_connections` option in the `network_acls` variable, it should be removed.
1 parent 884cac8 commit 276e463

File tree

4 files changed

+15
-17
lines changed

4 files changed

+15
-17
lines changed

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ You need the following permissions to run this module.
118118
| <a name="input_existing_storage_bucket_name"></a> [existing\_storage\_bucket\_name](#input\_existing\_storage\_bucket\_name) | Name of the COS bucket to collect VPC flow logs | `string` | `null` | no |
119119
| <a name="input_is_flow_log_collector_active"></a> [is\_flow\_log\_collector\_active](#input\_is\_flow\_log\_collector\_active) | Indicates whether the collector is active. If false, this collector is created in inactive mode. | `bool` | `true` | no |
120120
| <a name="input_name"></a> [name](#input\_name) | Name for VPC | `string` | n/a | yes |
121-
| <a name="input_network_acls"></a> [network\_acls](#input\_network\_acls) | List of ACLs to create. Rules can be automatically created to allow inbound and outbound traffic from a VPC tier by adding the name of that tier to the `network_connections` list. Rules automatically generated by these network connections will be added at the beginning of a list, and will be web-tierlied to traffic first. At least one rule must be provided for each ACL. | <pre>list(<br> object({<br> name = string<br> network_connections = optional(list(string))<br> add_ibm_cloud_internal_rules = optional(bool)<br> add_vpc_connectivity_rules = optional(bool)<br> prepend_ibm_rules = optional(bool)<br> rules = list(<br> object({<br> name = string<br> action = string<br> destination = string<br> direction = string<br> source = string<br> tcp = optional(<br> object({<br> port_max = optional(number)<br> port_min = optional(number)<br> source_port_max = optional(number)<br> source_port_min = optional(number)<br> })<br> )<br> udp = optional(<br> object({<br> port_max = optional(number)<br> port_min = optional(number)<br> source_port_max = optional(number)<br> source_port_min = optional(number)<br> })<br> )<br> icmp = optional(<br> object({<br> type = optional(number)<br> code = optional(number)<br> })<br> )<br> })<br> )<br> })<br> )</pre> | <pre>[<br> {<br> "add_ibm_cloud_internal_rules": true,<br> "add_vpc_connectivity_rules": true,<br> "name": "vpc-acl",<br> "prepend_ibm_rules": true,<br> "rules": []<br> }<br>]</pre> | no |
121+
| <a name="input_network_acls"></a> [network\_acls](#input\_network\_acls) | The list of ACLs to create. Provide at least one rule for each ACL. | <pre>list(<br> object({<br> name = string<br> add_ibm_cloud_internal_rules = optional(bool)<br> add_vpc_connectivity_rules = optional(bool)<br> prepend_ibm_rules = optional(bool)<br> rules = list(<br> object({<br> name = string<br> action = string<br> destination = string<br> direction = string<br> source = string<br> tcp = optional(<br> object({<br> port_max = optional(number)<br> port_min = optional(number)<br> source_port_max = optional(number)<br> source_port_min = optional(number)<br> })<br> )<br> udp = optional(<br> object({<br> port_max = optional(number)<br> port_min = optional(number)<br> source_port_max = optional(number)<br> source_port_min = optional(number)<br> })<br> )<br> icmp = optional(<br> object({<br> type = optional(number)<br> code = optional(number)<br> })<br> )<br> })<br> )<br> })<br> )</pre> | <pre>[<br> {<br> "add_ibm_cloud_internal_rules": true,<br> "add_vpc_connectivity_rules": true,<br> "name": "vpc-acl",<br> "prepend_ibm_rules": true,<br> "rules": []<br> }<br>]</pre> | no |
122122
| <a name="input_network_cidr"></a> [network\_cidr](#input\_network\_cidr) | Network CIDR for the VPC. This is used to manage network ACL rules for cluster provisioning. | `string` | `"10.0.0.0/8"` | no |
123123
| <a name="input_prefix"></a> [prefix](#input\_prefix) | The prefix that you would like to append to your resources | `string` | n/a | yes |
124124
| <a name="input_region"></a> [region](#input\_region) | The region to which to deploy the VPC | `string` | n/a | yes |

‎dynamic_values/variables.tf‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,9 +123,8 @@ variable "network_acls" {
123123
description = "direct reference to network acls"
124124
type = list(
125125
object({
126-
name = string
127-
network_connections = optional(list(string))
128-
add_cluster_rules = optional(bool)
126+
name = string
127+
add_cluster_rules = optional(bool)
129128
rules = list(
130129
object({
131130
name = string

‎module-metadata.json‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
"default": false,
4040
"pos": {
4141
"filename": "variables.tf",
42-
"line": 415
42+
"line": 414
4343
}
4444
},
4545
"default_network_acl_name": {
@@ -101,7 +101,7 @@
101101
],
102102
"pos": {
103103
"filename": "variables.tf",
104-
"line": 409
104+
"line": 408
105105
}
106106
},
107107
"existing_cos_instance_guid": {
@@ -113,7 +113,7 @@
113113
],
114114
"pos": {
115115
"filename": "variables.tf",
116-
"line": 421
116+
"line": 420
117117
},
118118
"immutable": true,
119119
"computed": true
@@ -128,7 +128,7 @@
128128
],
129129
"pos": {
130130
"filename": "variables.tf",
131-
"line": 427
131+
"line": 426
132132
},
133133
"immutable": true
134134
},
@@ -142,7 +142,7 @@
142142
],
143143
"pos": {
144144
"filename": "variables.tf",
145-
"line": 433
145+
"line": 432
146146
}
147147
},
148148
"name": {
@@ -157,8 +157,8 @@
157157
},
158158
"network_acls": {
159159
"name": "network_acls",
160-
"type": "list(\n object({\n name = string\n network_connections = optional(list(string))\n add_ibm_cloud_internal_rules = optional(bool)\n add_vpc_connectivity_rules = optional(bool)\n prepend_ibm_rules = optional(bool)\n rules = list(\n object({\n name = string\n action = string\n destination = string\n direction = string\n source = string\n tcp = optional(\n object({\n port_max = optional(number)\n port_min = optional(number)\n source_port_max = optional(number)\n source_port_min = optional(number)\n })\n )\n udp = optional(\n object({\n port_max = optional(number)\n port_min = optional(number)\n source_port_max = optional(number)\n source_port_min = optional(number)\n })\n )\n icmp = optional(\n object({\n type = optional(number)\n code = optional(number)\n })\n )\n })\n )\n })\n )",
161-
"description": "List of ACLs to create. Rules can be automatically created to allow inbound and outbound traffic from a VPC tier by adding the name of that tier to the `network_connections` list. Rules automatically generated by these network connections will be added at the beginning of a list, and will be web-tierlied to traffic first. At least one rule must be provided for each ACL.",
160+
"type": "list(\n object({\n name = string\n add_ibm_cloud_internal_rules = optional(bool)\n add_vpc_connectivity_rules = optional(bool)\n prepend_ibm_rules = optional(bool)\n rules = list(\n object({\n name = string\n action = string\n destination = string\n direction = string\n source = string\n tcp = optional(\n object({\n port_max = optional(number)\n port_min = optional(number)\n source_port_max = optional(number)\n source_port_min = optional(number)\n })\n )\n udp = optional(\n object({\n port_max = optional(number)\n port_min = optional(number)\n source_port_max = optional(number)\n source_port_min = optional(number)\n })\n )\n icmp = optional(\n object({\n type = optional(number)\n code = optional(number)\n })\n )\n })\n )\n })\n )",
161+
"description": "The list of ACLs to create. Provide at least one rule for each ACL.",
162162
"default": [
163163
{
164164
"add_ibm_cloud_internal_rules": true,
@@ -256,7 +256,7 @@
256256
],
257257
"pos": {
258258
"filename": "variables.tf",
259-
"line": 381
259+
"line": 380
260260
}
261261
},
262262
"security_group_rules": {
@@ -275,7 +275,7 @@
275275
],
276276
"pos": {
277277
"filename": "variables.tf",
278-
"line": 315
278+
"line": 314
279279
}
280280
},
281281
"subnets": {
@@ -313,7 +313,7 @@
313313
],
314314
"pos": {
315315
"filename": "variables.tf",
316-
"line": 252
316+
"line": 251
317317
}
318318
},
319319
"tags": {
@@ -367,7 +367,7 @@
367367
],
368368
"pos": {
369369
"filename": "variables.tf",
370-
"line": 226
370+
"line": 225
371371
}
372372
}
373373
},

‎variables.tf‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,11 +96,10 @@ variable "address_prefixes" {
9696
##############################################################################
9797

9898
variable "network_acls" {
99-
description = "List of ACLs to create. Rules can be automatically created to allow inbound and outbound traffic from a VPC tier by adding the name of that tier to the `network_connections` list. Rules automatically generated by these network connections will be added at the beginning of a list, and will be web-tierlied to traffic first. At least one rule must be provided for each ACL."
99+
description = "The list of ACLs to create. Provide at least one rule for each ACL."
100100
type = list(
101101
object({
102102
name = string
103-
network_connections = optional(list(string))
104103
add_ibm_cloud_internal_rules = optional(bool)
105104
add_vpc_connectivity_rules = optional(bool)
106105
prepend_ibm_rules = optional(bool)

0 commit comments

Comments
 (0)