resolve review comments

Author: Khuzaima-Shakeel

ibm_catalog.json

@@ -403,7 +403,17 @@
               "key": "flow_logs_cos_bucket_archive_days"
             },
             {
-              "key": "flow_logs_cos_bucket_archive_type"
+              "key": "flow_logs_cos_bucket_archive_type",
+              "options": [
+                {
+                  "displayname": "Glacier",
+                  "value": "Glacier"
+                },
+                {
+                  "displayname": "Accelerated",
+                  "value": "Accelerated"
+                }
+              ]
             },
             {
               "key": "flow_logs_cos_bucket_expire_days"

solutions/fully-configurable/variables.tf

@@ -502,6 +502,10 @@ variable "flow_logs_cos_bucket_archive_type" {
   description = "The storage class or archive type you want the object to transition to in the flow logs cloud object storage bucket."
   type        = string
   default     = "Glacier"
+  validation {
+    condition     = contains(["Glacier", "Accelerated"], var.flow_logs_cos_bucket_archive_type)
+    error_message = "The specified flow_logs_cos_bucket_archive_type is not a valid selection!"
+  }
 }
 
 variable "flow_logs_cos_bucket_expire_days" {

tests/pr_test.go

@@ -232,7 +232,7 @@ func TestFullyConfigurable(t *testing.T) {
 		TemplateFolder:         fullyConfigFlavorDir,
 		Tags:                   []string{"vpc-da-test"},
 		DeleteWorkspaceOnFail:  false,
-		WaitJobCompleteMinutes: 60,
+		WaitJobCompleteMinutes: 120,
 	})
 
 	options.TerraformVars = []testschematic.TestSchematicTerraformVar{
@@ -276,7 +276,7 @@ func TestRunUpgradeFullyConfigurable(t *testing.T) {
 		TemplateFolder:         fullyConfigFlavorDir,
 		Tags:                   []string{"vpc-da-test"},
 		DeleteWorkspaceOnFail:  false,
-		WaitJobCompleteMinutes: 60,
+		WaitJobCompleteMinutes: 120,
 	})
 
 	options.TerraformVars = []testschematic.TestSchematicTerraformVar{