fix: Support to allow VPC to access classic infrastructure network is removed as classic_access feature has been deprecated by provider (#885)

Support to allow VPC to access classic infrastructure network has been removed as `classic_access` feature has been deprecated by provider (#885)
---------

Co-authored-by: Aatreyee Mukherjee <[email protected]>

Author: aatreyee2506

README.md

@@ -179,7 +179,6 @@ To attach access management tags to resources in this module, you need the follo
 |------|-------------|------|---------|:--------:|
 | <a name="input_access_tags"></a> [access\_tags](#input\_access\_tags) | A list of access tags to apply to the VPC resources created by the module. For more information, see https://cloud.ibm.com/docs/account?topic=account-access-tags-tutorial. | `list(string)` | `[]` | no |
 | <a name="input_address_prefixes"></a> [address\_prefixes](#input\_address\_prefixes) | OPTIONAL - IP range that will be defined for the VPC for a certain location. Use only with manual address prefixes | <pre>object({<br/>    zone-1 = optional(list(string))<br/>    zone-2 = optional(list(string))<br/>    zone-3 = optional(list(string))<br/>  })</pre> | <pre>{<br/>  "zone-1": null,<br/>  "zone-2": null,<br/>  "zone-3": null<br/>}</pre> | no |
-| <a name="input_classic_access"></a> [classic\_access](#input\_classic\_access) | OPTIONAL - Classic Access to the VPC | `bool` | `false` | no |
 | <a name="input_clean_default_sg_acl"></a> [clean\_default\_sg\_acl](#input\_clean\_default\_sg\_acl) | Remove all rules from the default VPC security group and VPC ACL (less permissive) | `bool` | `false` | no |
 | <a name="input_create_authorization_policy_vpc_to_cos"></a> [create\_authorization\_policy\_vpc\_to\_cos](#input\_create\_authorization\_policy\_vpc\_to\_cos) | Create authorisation policy for VPC to access COS. Set as false if authorization policy exists already | `bool` | `false` | no |
 | <a name="input_create_subnets"></a> [create\_subnets](#input\_create\_subnets) | Indicates whether user wants to use existing subnets or create new. Set it to true to create new subnets. | `bool` | `true` | no |

main.tf

@@ -71,7 +71,6 @@ resource "ibm_is_vpc" "vpc" {
   count          = var.create_vpc == true ? 1 : 0
   name           = var.prefix != null ? "${var.prefix}-${var.name}-vpc" : var.name
   resource_group = var.resource_group_id
-  classic_access = var.classic_access
   # address prefix is set to auto only if no address prefixes NOR any subnet is passed as input
   address_prefix_management   = (length([for prefix in values(coalesce(var.address_prefixes, {})) : prefix if prefix != null]) != 0) || (length([for subnet in values(coalesce(var.subnets, {})) : subnet if subnet != null]) != 0) ? "manual" : null
   default_network_acl_name    = var.default_network_acl_name

modules/management-vpc/README.md

@@ -40,7 +40,6 @@ No resources.
 |------|-------------|------|---------|:--------:|
 | <a name="input_access_tags"></a> [access\_tags](#input\_access\_tags) | Optional list of access tags to add to the VPC resources that are created | `list(string)` | `[]` | no |
 | <a name="input_address_prefixes"></a> [address\_prefixes](#input\_address\_prefixes) | Use `address_prefixes` only if `use_manual_address_prefixes` is true otherwise prefixes will not be created. Use only if you need to manage prefixes manually. | <pre>object({<br/>    zone-1 = optional(list(string))<br/>    zone-2 = optional(list(string))<br/>    zone-3 = optional(list(string))<br/>  })</pre> | `null` | no |
-| <a name="input_classic_access"></a> [classic\_access](#input\_classic\_access) | Optionally allow VPC to access classic infrastructure network | `bool` | `null` | no |
 | <a name="input_clean_default_sg_acl"></a> [clean\_default\_sg\_acl](#input\_clean\_default\_sg\_acl) | Remove all rules from the default VPC security group and VPC ACL (less permissive) | `bool` | `false` | no |
 | <a name="input_create_authorization_policy_vpc_to_cos"></a> [create\_authorization\_policy\_vpc\_to\_cos](#input\_create\_authorization\_policy\_vpc\_to\_cos) | Set it to true if authorization policy is required for VPC to access COS | `bool` | `false` | no |
 | <a name="input_default_network_acl_name"></a> [default\_network\_acl\_name](#input\_default\_network\_acl\_name) | Override default ACL name | `string` | `null` | no |

modules/management-vpc/main.tf

@@ -11,7 +11,6 @@ module "management_vpc" {
   region                                 = var.region
   prefix                                 = var.prefix
   network_cidrs                          = var.network_cidrs
-  classic_access                         = var.classic_access
   default_network_acl_name               = var.default_network_acl_name
   default_security_group_name            = var.default_security_group_name
   security_group_rules                   = var.default_security_group_rules == null ? [] : var.default_security_group_rules

modules/management-vpc/variables.tf

@@ -37,12 +37,6 @@ variable "network_cidrs" {
   default     = ["10.0.0.0/8"]
 }
 
-variable "classic_access" {
-  description = "Optionally allow VPC to access classic infrastructure network"
-  type        = bool
-  default     = null
-}
-
 variable "default_network_acl_name" {
   description = "Override default ACL name"
   type        = string

modules/workload-vpc/README.md

@@ -40,7 +40,6 @@ No resources.
 |------|-------------|------|---------|:--------:|
 | <a name="input_access_tags"></a> [access\_tags](#input\_access\_tags) | Optional list of access tags to add to the VPC resources that are created | `list(string)` | `[]` | no |
 | <a name="input_address_prefixes"></a> [address\_prefixes](#input\_address\_prefixes) | Use `address_prefixes` only if `use_manual_address_prefixes` is true otherwise prefixes will not be created. Use only if you need to manage prefixes manually. | <pre>object({<br/>    zone-1 = optional(list(string))<br/>    zone-2 = optional(list(string))<br/>    zone-3 = optional(list(string))<br/>  })</pre> | `null` | no |
-| <a name="input_classic_access"></a> [classic\_access](#input\_classic\_access) | Optionally allow VPC to access classic infrastructure network | `bool` | `null` | no |
 | <a name="input_clean_default_sg_acl"></a> [clean\_default\_sg\_acl](#input\_clean\_default\_sg\_acl) | Remove all rules from the default VPC security group and VPC ACL (less permissive) | `bool` | `false` | no |
 | <a name="input_create_authorization_policy_vpc_to_cos"></a> [create\_authorization\_policy\_vpc\_to\_cos](#input\_create\_authorization\_policy\_vpc\_to\_cos) | Set it to true if authorization policy is required for VPC to access COS | `bool` | `false` | no |
 | <a name="input_default_network_acl_name"></a> [default\_network\_acl\_name](#input\_default\_network\_acl\_name) | Override default ACL name | `string` | `null` | no |

modules/workload-vpc/main.tf

@@ -11,7 +11,6 @@ module "workload_vpc" {
   region                                 = var.region
   prefix                                 = var.prefix
   network_cidrs                          = var.network_cidrs
-  classic_access                         = var.classic_access
   default_network_acl_name               = var.default_network_acl_name
   default_security_group_name            = var.default_security_group_name
   security_group_rules                   = var.default_security_group_rules == null ? [] : var.default_security_group_rules

modules/workload-vpc/variables.tf

@@ -37,13 +37,6 @@ variable "network_cidrs" {
   default     = ["10.0.0.0/8"]
 }
 
-variable "classic_access" {
-  description = "Optionally allow VPC to access classic infrastructure network"
-  type        = bool
-  default     = null
-}
-
-
 variable "default_network_acl_name" {
   description = "Override default ACL name"
   type        = string

variables.tf

@@ -106,12 +106,6 @@ variable "network_cidrs" {
   default     = ["10.0.0.0/8"]
 }
 
-variable "classic_access" {
-  description = "OPTIONAL - Classic Access to the VPC"
-  type        = bool
-  default     = false
-}
-
 variable "default_network_acl_name" {
   description = "OPTIONAL - Name of the Default ACL. If null, a name will be automatically generated"
   type        = string