Skip to content

Commit d80134a

Browse files
Khuzaima05Khuzaima-ShakeelShikha Maheshwarimaheshwarishikhavburckhardt
authored
feat: addressed DA improvements for better user experience<br>- pinned the addons version<br>- added more details in UI(catalog tile) regarding DA overview, features, architecture & variation<br>- updated DA architecture diagram to include on_by_default addons<br>Updated prefix input variable description and validation for DA<br>updated the default value of variable subnet. By default subnets will be created in three zones for high-availability. Because of this there will be update-in-place for network ACLs while you upgrade an existing infrastructure<br>require ibm provider 1.79.0 or later to pull in fix for [provider issue](IBM-Cloud/terraform-provider-ibm#6269). The DA has been locked to 1.79.0<br>(#998)
* fix: updated vpc catalog and reference architecture * update catalog * update catalog * update catalog * fix arch * fix arch * update code * updated overview and features * update code * fix code * prefix doc * Update DA-prefix.md * update desc * fix typo * Migrate dependencies for VPC * update ref_arch * update ref_arch * fix cos mapping * update cos version * update cos version * fix kms * resolve review comments * updated kms add-on * updated kms description * minor fix * update architecture description * delete prefix.md * resolve review comments * updated description * updated label * Update ibm_catalog.json Co-authored-by: Shikha Maheshwari <[email protected]> * Update ibm_catalog.json * fix minor issues * updated observability permission * updated descriptions in catalog config * update ref arch and catalog json * update provider version * fix provider version and pre-commit failure * SKIP UPGRADE TEST * updated provider version * updated add-ons version * updated obervability mapping * update dependencies version --------- Co-authored-by: Khuzaima-Shakeel <[email protected]> Co-authored-by: Shikha Maheshwari <[email protected]> Co-authored-by: Shikha Maheshwari <[email protected]> Co-authored-by: Vincent Burckhardt <[email protected]>
1 parent 585750b commit d80134a

File tree

14 files changed

+179
-182
lines changed

14 files changed

+179
-182
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ To attach access management tags to resources in this module, you need the follo
136136
| Name | Version |
137137
|------|---------|
138138
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.9.0 |
139-
| <a name="requirement_ibm"></a> [ibm](#requirement\_ibm) | >= 1.59.0, < 2.0.0 |
139+
| <a name="requirement_ibm"></a> [ibm](#requirement\_ibm) | >= 1.79.0, < 2.0.0 |
140140
| <a name="requirement_time"></a> [time](#requirement\_time) | >= 0.9.1, < 1.0.0 |
141141

142142
### Modules

cra-config.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
# More info about this file at https://github.com/terraform-ibm-modules/common-pipeline-assets/blob/main/.github/workflows/terraform-test-pipeline.md#cra-config-yaml
22
version: "v1"
33
CRA_TARGETS:
4-
- CRA_TARGET: "examples/default" # Target directory for CRA scan. If not provided, the CRA Scan will not be run.
4+
- CRA_TARGET: "solutions/fully-configurable" # Target directory for CRA scan. If not provided, the CRA Scan will not be run.
55
CRA_IGNORE_RULES_FILE: "cra-tf-validate-ignore-rules.json" # CRA Ignore file to use. If not provided, it checks the repo root directory for `cra-tf-validate-ignore-rules.json`
66
PROFILE_ID: "fe96bd4d-9b37-40f2-b39f-a62760e326a3" # SCC profile ID (currently set to 'IBM Cloud Framework for Financial Services' '1.7.0' profile).
77
CRA_ENVIRONMENT_VARIABLES: # An optional map of environment variables for CRA, where the key is the variable name and value is the value. Useful for providing TF_VARs.
8-
TF_VAR_region: "us-south"
9-
TF_VAR_prefix: "def-slz-vpc"
8+
TF_VAR_provider_visibility: "public"
9+
TF_VAR_prefix: "vpc-fc"

examples/basic/version.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ terraform {
55
# module's version.tf (basic), and 1 example that will always use the latest provider version.
66
ibm = {
77
source = "IBM-Cloud/ibm"
8-
version = "1.59.0"
8+
version = ">=1.59.0"
99
}
1010
}
1111
}

examples/specific-zone-only/version.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ terraform {
44
# Pin to the lowest provider version of the range defined in the main module's version.tf to ensure lowest version still works
55
ibm = {
66
source = "IBM-Cloud/ibm"
7-
version = "1.59.0"
7+
version = ">=1.59.0"
88
}
99
}
1010
}

examples/vpc-with-dns/version.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ terraform {
44
# Pin to the lowest provider version of the range defined in the main module's version.tf to ensure lowest version still works
55
ibm = {
66
source = "IBM-Cloud/ibm"
7-
version = "1.59.0"
7+
version = ">=1.59.0"
88
}
99
}
1010
}

ibm_catalog.json

Lines changed: 135 additions & 159 deletions
Large diffs are not rendered by default.

images/vpc_icon.svg

Lines changed: 1 addition & 1 deletion
Loading

reference-architecture/deployable-architecture-vpc.svg

Lines changed: 1 addition & 1 deletion
Loading

0 commit comments

Comments
 (0)