fix: resolved review comments

Author: imprateeksh

README.md

@@ -151,7 +151,7 @@ To attach access management tags to resources in this module, you need the follo
 | Name | Type |
 |------|------|
 | [ibm_dns_custom_resolver.custom_resolver_hub](https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/dns_custom_resolver) | resource |
-| [ibm_dns_permitted_network.dns_permitted_nw](https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/dns_permitted_network) | resource |
+| [ibm_dns_permitted_network.dns_permitted_network](https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/dns_permitted_network) | resource |
 | [ibm_dns_resource_record.dns_record](https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/dns_resource_record) | resource |
 | [ibm_dns_zone.dns_zone](https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/dns_zone) | resource |
 | [ibm_iam_authorization_policy.policy](https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/iam_authorization_policy) | resource |
@@ -198,7 +198,7 @@ To attach access management tags to resources in this module, you need the follo
 | <a name="input_dns_records"></a> [dns\_records](#input\_dns\_records) | List of DNS records to be created. | <pre>list(object({<br/>    name       = string<br/>    type       = string<br/>    ttl        = number<br/>    rdata      = string<br/>    preference = optional(number, null)<br/>    service    = optional(string, null)<br/>    protocol   = optional(string, null)<br/>    priority   = optional(number, null)<br/>    weight     = optional(number, null)<br/>    port       = optional(number, null)<br/>  }))</pre> | `[]` | no |
 | <a name="input_dns_zone_description"></a> [dns\_zone\_description](#input\_dns\_zone\_description) | The description of the DNS zone. | `string` | `"Default DNS Zone"` | no |
 | <a name="input_dns_zone_label"></a> [dns\_zone\_label](#input\_dns\_zone\_label) | Label associated with the DNS zone. | `string` | `"dns-zone"` | no |
-| <a name="input_dns_zone_name"></a> [dns\_zone\_name](#input\_dns\_zone\_name) | The name of the DNS zone to be created. | `string` | `null` | no |
+| <a name="input_dns_zone_name"></a> [dns\_zone\_name](#input\_dns\_zone\_name) | The name of the DNS zone to be created. | `string` | `"slz.com"` | no |
 | <a name="input_enable_hub"></a> [enable\_hub](#input\_enable\_hub) | Indicates whether this VPC is enabled as a DNS name resolution hub. | `bool` | `false` | no |
 | <a name="input_enable_hub_vpc_crn"></a> [enable\_hub\_vpc\_crn](#input\_enable\_hub\_vpc\_crn) | Indicates whether Hub VPC CRN is passed. | `bool` | `false` | no |
 | <a name="input_enable_hub_vpc_id"></a> [enable\_hub\_vpc\_id](#input\_enable\_hub\_vpc\_id) | Indicates whether Hub VPC ID is passed. | `bool` | `false` | no |
@@ -244,8 +244,7 @@ To attach access management tags to resources in this module, you need the follo
 | <a name="output_dns_endpoint_gateways_by_id"></a> [dns\_endpoint\_gateways\_by\_id](#output\_dns\_endpoint\_gateways\_by\_id) | The list of VPEs that are made available for DNS resolution in the created VPC. Only set if enable\_hub is false and enable\_hub\_vpc\_id are true. |
 | <a name="output_dns_instance_id"></a> [dns\_instance\_id](#output\_dns\_instance\_id) | The ID of the DNS instance. |
 | <a name="output_dns_record_ids"></a> [dns\_record\_ids](#output\_dns\_record\_ids) | List of all the domain resource records. |
-| <a name="output_dns_zone"></a> [dns\_zone](#output\_dns\_zone) | The ID of the DNS zone. The ID is composed of <instance\_id>/<zone\_id> |
-| <a name="output_dns_zone_id"></a> [dns\_zone\_id](#output\_dns\_zone\_id) | The ID of the zone that is associated with the DNS zone. |
+| <a name="output_dns_zone_id"></a> [dns\_zone\_id](#output\_dns\_zone\_id) | The ID of the DNS zone. |
 | <a name="output_dns_zone_state"></a> [dns\_zone\_state](#output\_dns\_zone\_state) | The state of the DNS zone. |
 | <a name="output_network_acls"></a> [network\_acls](#output\_network\_acls) | List of shortnames and IDs of network ACLs |
 | <a name="output_public_gateways"></a> [public\_gateways](#output\_public\_gateways) | Map of public gateways by zone |

examples/vpc-with-dns/README.md

@@ -1,6 +1,6 @@
 # VPC with DNS example
 
-A simple example to provision a Secure Landing Zone (SLZ) Virtual Private Cloud (`VPC`) in two zones (Zone1 and Zone2). Allows creation of Domain Name System (`DNS`) `Zones` and `Records` linking the created `VPC` as a permitted network to the `DNS.`
+A simple example demonstrating the provisioning of a `Secure Landing Zone (SLZ) Virtual Private Cloud (VPC)` across two zones (`Zone 1` and `Zone 2`). This setup includes the creation of `Domain Name System (DNS) Zones and Records`, linking the provisioned VPC as a permitted network for DNS operations.
 
 The following resources are provisioned by this example:
 

examples/vpc-with-dns/outputs.tf

@@ -37,13 +37,8 @@ output "dns_zone_state" {
   value       = module.slz_vpc.dns_zone_state
 }
 
-output "dns_zone" {
-  description = "The ID of the DNS zone. The ID is composed of <instance_id>/<zone_id>"
-  value       = module.slz_vpc.dns_zone
-}
-
 output "dns_zone_id" {
-  description = "The ID of the zone that is associated with the DNS zone."
+  description = "The ID of the DNS zone."
   value       = module.slz_vpc.dns_zone_id
 }
 output "dns_record_ids" {

examples/vpc-with-dns/variables.tf

@@ -19,7 +19,7 @@ variable "prefix" {
 variable "name" {
   description = "The name of the vpc"
   type        = string
-  default     = "sz-vpc"
+  default     = "slz-vpc"
 }
 
 variable "resource_group" {
@@ -48,9 +48,40 @@ variable "dns_records" {
     service    = optional(string)
     weight     = optional(number)
   }))
+  default = [
+    {
+      name  = "testA"
+      type  = "A"
+      rdata = "1.2.3.4"
+      ttl   = 3600
+    },
+    {
+      name       = "testMX"
+      type       = "MX"
+      rdata      = "mailserver.test.com"
+      preference = 10
+    },
+    {
+      type     = "SRV"
+      name     = "testSRV"
+      rdata    = "tester.com"
+      priority = 100
+      weight   = 100
+      port     = 8000
+      service  = "_sip"
+      protocol = "udp"
+    },
+    {
+      name  = "testTXT"
+      type  = "TXT"
+      rdata = "textinformation"
+      ttl   = 900
+    }
+  ]
 }
 
 variable "dns_zone_name" {
   description = "The name of the DNS zone to be created."
   type        = string
+  default     = "dns-example.com"
 }

main.tf

@@ -370,7 +370,7 @@ resource "ibm_dns_zone" "dns_zone" {
 # DNS PERMITTED NETWORK
 ##############################################################################
 
-resource "ibm_dns_permitted_network" "dns_permitted_nw" {
+resource "ibm_dns_permitted_network" "dns_permitted_network" {
   count       = var.enable_hub && !var.skip_custom_resolver_hub_creation ? 1 : 0
   instance_id = var.use_existing_dns_instance ? var.existing_dns_instance_id : ibm_resource_instance.dns_instance_hub[0].guid
   zone_id     = ibm_dns_zone.dns_zone[0].zone_id
@@ -382,6 +382,9 @@ resource "ibm_dns_permitted_network" "dns_permitted_nw" {
 # DNS Records
 ##############################################################################
 
+locals {
+  record_ids = [for record in ibm_dns_resource_record.dns_record : element(split("/", record.id), 2)]
+}
 resource "ibm_dns_resource_record" "dns_record" {
 
   for_each    = { for idx, record in var.dns_records : idx => record }

outputs.tf

@@ -183,17 +183,12 @@ output "dns_zone_state" {
   value       = length(ibm_dns_zone.dns_zone) > 0 ? ibm_dns_zone.dns_zone[0].state : null
 }
 
-output "dns_zone" {
-  description = "The ID of the DNS zone. The ID is composed of <instance_id>/<zone_id>"
-  value       = length(ibm_dns_zone.dns_zone) > 0 ? ibm_dns_zone.dns_zone[0].id : null
-}
-
 output "dns_zone_id" {
-  description = "The ID of the zone that is associated with the DNS zone."
+  description = "The ID of the DNS zone."
   value       = length(ibm_dns_zone.dns_zone) > 0 ? ibm_dns_zone.dns_zone[0].zone_id : null
 }
 
 output "dns_record_ids" {
   description = "List of all the domain resource records."
-  value       = [for record in ibm_dns_resource_record.dns_record : record.id]
+  value       = length(ibm_dns_resource_record.dns_record) > 0 ? local.record_ids : null
 }

variables.tf

@@ -640,7 +640,7 @@ variable "dns_plan" {
 
 variable "dns_zone_name" {
   description = "The name of the DNS zone to be created."
-  default     = null
+  default     = "slz.com"
   type        = string
 }