fix: resolved review comments

Author: imprateeksh

README.md

@@ -244,6 +244,7 @@ To attach access management tags to resources in this module, you need the follo
 | <a name="output_dns_endpoint_gateways_by_id"></a> [dns\_endpoint\_gateways\_by\_id](#output\_dns\_endpoint\_gateways\_by\_id) | The list of VPEs that are made available for DNS resolution in the created VPC. Only set if enable\_hub is false and enable\_hub\_vpc\_id are true. |
 | <a name="output_dns_instance_id"></a> [dns\_instance\_id](#output\_dns\_instance\_id) | The ID of the DNS instance. |
 | <a name="output_dns_record_ids"></a> [dns\_record\_ids](#output\_dns\_record\_ids) | List of all the domain resource records. |
+| <a name="output_dns_zone"></a> [dns\_zone](#output\_dns\_zone) | A map representing DNS zone information. |
 | <a name="output_dns_zone_id"></a> [dns\_zone\_id](#output\_dns\_zone\_id) | The ID of the DNS zone. |
 | <a name="output_dns_zone_state"></a> [dns\_zone\_state](#output\_dns\_zone\_state) | The state of the DNS zone. |
 | <a name="output_network_acls"></a> [network\_acls](#output\_network\_acls) | List of shortnames and IDs of network ACLs |

examples/vpc-with-dns/outputs.tf

@@ -45,3 +45,8 @@ output "dns_record_ids" {
   description = "List of all the domain resource records."
   value       = module.slz_vpc.dns_record_ids
 }
+
+output "dns_zone" {
+  description = "A map representing DNS zone information."
+  value       = module.slz_vpc.dns_zone
+}

main.tf

@@ -382,9 +382,6 @@ resource "ibm_dns_permitted_network" "dns_permitted_network" {
 # DNS Records
 ##############################################################################
 
-locals {
-  record_ids = [for record in ibm_dns_resource_record.dns_record : element(split("/", record.id), 2)]
-}
 resource "ibm_dns_resource_record" "dns_record" {
 
   for_each    = { for idx, record in var.dns_records : idx => record }
@@ -408,4 +405,8 @@ resource "ibm_dns_resource_record" "dns_record" {
   preference = each.value.type == "MX" ? each.value.preference : null
 }
 
+locals {
+  record_ids = [for record in ibm_dns_resource_record.dns_record : element(split("/", record.id), 2)]
+}
+
 ##############################################################################

outputs.tf

@@ -188,6 +188,11 @@ output "dns_zone_id" {
   value       = length(ibm_dns_zone.dns_zone) > 0 ? ibm_dns_zone.dns_zone[0].zone_id : null
 }
 
+output "dns_zone" {
+  description = "A map representing DNS zone information."
+  value       = length(ibm_dns_zone.dns_zone) > 0 ? ibm_dns_zone.dns_zone[0] : null
+}
+
 output "dns_record_ids" {
   description = "List of all the domain resource records."
   value       = length(ibm_dns_resource_record.dns_record) > 0 ? local.record_ids : null

variables.tf

@@ -642,6 +642,22 @@ variable "dns_zone_name" {
   description = "The name of the DNS zone to be created."
   default     = "slz.com"
   type        = string
+  validation {
+    condition = !contains([
+      "ibm.com",
+      "softlayer.com",
+      "bluemix.net",
+      "softlayer.local",
+      "mybluemix.net",
+      "networklayer.com",
+      "ibmcloud.com",
+      "pdnsibm.net",
+      "appdomain.cloud",
+      "compass.cobaltiron.com"
+    ], var.dns_zone_name)
+
+    error_message = "The specified DNS zone name is not permitted. Please choose a different domain name. [Learn more](https://cloud.ibm.com/docs/dns-svcs?topic=dns-svcs-managing-dns-zones&interface=ui#restricted-dns-zone-names)"
+  }
 }
 
 variable "dns_zone_description" {