Skip to content

Conversation

@whoffler
Copy link
Contributor

Description

for issue - https://github.ibm.com/GoldenEye/issues/issues/15223

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@whoffler
Copy link
Contributor Author

when terraform-ibm-modules/terraform-ibm-resource-group#728 is merged, will update the version of the resource group module used here

@whoffler
Copy link
Contributor Author

whoffler commented Aug 1, 2025

/run pipeline

@vburckhardt
Copy link
Member

Just make sure to actually test that the code change is genuinely solving the issue. I suggest to change the default rg group name to 'default' in the dev account.

@whoffler
Copy link
Contributor Author

whoffler commented Aug 1, 2025

@vburckhardt tested with my own account where default is the default resource group

# module.vpc.ibm_is_vpc.vpc[0] will be created
  + resource "ibm_is_vpc" "vpc" {
      ...
      + resource_group              = "8789ec5bc96742b3b7d729a8302c37c7"
image

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @vburckhardt Let me know if any concerns, otherwise I will merge

@ocofaigh
Copy link
Contributor

ocofaigh commented Aug 1, 2025

/run pipeline

@whoffler whoffler force-pushed the defaultResourceGroup branch from b6a9912 to bb60f7f Compare August 4, 2025 23:02
@whoffler
Copy link
Contributor Author

whoffler commented Aug 4, 2025

/run pipeline

1 similar comment
@whoffler
Copy link
Contributor Author

whoffler commented Aug 4, 2025

/run pipeline

@ocofaigh ocofaigh merged commit b6985a0 into main Aug 5, 2025
2 checks passed
@ocofaigh ocofaigh deleted the defaultResourceGroup branch August 5, 2025 07:30
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 7.25.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants