Skip to content

Conversation

@Aditya-ranjan-16
Copy link
Contributor

Description

https://github.ibm.com/GoldenEye/issues/issues/14047

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aditya-ranjan-16 Aditya-ranjan-16 marked this pull request as ready for review August 25, 2025 14:41
Copy link
Member

@maheshwarishikha maheshwarishikha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes are required, as per the discussion in DA rally. Please check rally recording for more details. Some of those are:

  • * dependencies description
  • * diagram labels
  • * change variation name
  • * some changes in fully configurable DA diagram

@ocofaigh
Copy link
Contributor

ocofaigh commented Sep 1, 2025

FYI, #1040 should be merged before this one please

@ocofaigh
Copy link
Contributor

ocofaigh commented Sep 2, 2025

@Aditya-ranjan-16 Can you resolve conflicts now that dependant PR is merged - lets see if we can get this one merged today

@ocofaigh
Copy link
Contributor

ocofaigh commented Sep 3, 2025

/run pipeline

ocofaigh
ocofaigh previously approved these changes Sep 3, 2025
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aditya-ranjan-16 I think we need to update addon test to use landing zone tile:
[TestVpcAddonDefaultConfiguration] CRITICAL ERROR: Error importing the offering: Unable to preprocess repo content: Error[400 Bad Request] - Could not find a product named 'deploy-arch-ibm-vpc' with product kind deployable architecture (solution) in the specified catalog manifest

@Aditya-ranjan-16
Copy link
Contributor Author

@Aditya-ranjan-16 I think we need to update addon test to use landing zone tile: [TestVpcAddonDefaultConfiguration] CRITICAL ERROR: Error importing the offering: Unable to preprocess repo content: Error[400 Bad Request] - Could not find a product named 'deploy-arch-ibm-vpc' with product kind deployable architecture (solution) in the specified catalog manifest

updated

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Contributor

ocofaigh commented Sep 3, 2025

/run pipeline

1 similar comment
@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Contributor

ocofaigh commented Sep 3, 2025

TestRunHubAndSpokeDelegatedExample 2025-09-03T19:33:25Z command.go:206: ╷
TestRunHubAndSpokeDelegatedExample 2025-09-03T19:33:25Z command.go:206: │ Error: timeout while waiting for state to become ', detached' (last state: 'deleting', timeout: 10m0s)
TestRunHubAndSpokeDelegatedExample 2025-09-03T19:33:25Z command.go:206: │ 
TestRunHubAndSpokeDelegatedExample 2025-09-03T19:33:25Z command.go:206: │ ---
TestRunHubAndSpokeDelegatedExample 2025-09-03T19:33:25Z command.go:206: │ id: terraform-3c89fecc
TestRunHubAndSpokeDelegatedExample 2025-09-03T19:33:25Z command.go:206: │ summary: 'timeout while waiting for state to become '', detached'' (last
TestRunHubAndSpokeDelegatedExample 2025-09-03T19:33:25Z command.go:206: │ state: ''deleting'',
TestRunHubAndSpokeDelegatedExample 2025-09-03T19:33:25Z command.go:206: │   timeout: 10m0s)'
TestRunHubAndSpokeDelegatedExample 2025-09-03T19:33:25Z command.go:206: │ severity: error
TestRunHubAndSpokeDelegatedExample 2025-09-03T19:33:25Z command.go:206: │ resource: ibm_tg_connection
TestRunHubAndSpokeDelegatedExample 2025-09-03T19:33:25Z command.go:206: │ operation: delete
TestRunHubAndSpokeDelegatedExample 2025-09-03T19:33:25Z command.go:206: │ component:
TestRunHubAndSpokeDelegatedExample 2025-09-03T19:33:25Z command.go:206: │   name: github.com/IBM-Cloud/terraform-provider-ibm
TestRunHubAndSpokeDelegatedExample 2025-09-03T19:33:25Z command.go:206: │   version: 1.82.1
TestRunHubAndSpokeDelegatedExample 2025-09-03T19:33:25Z command.go:206: │ ---

Failure unrelated to changes in this PR, re-running..

@ocofaigh
Copy link
Contributor

ocofaigh commented Sep 3, 2025

/run pipeline

1 similar comment
@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@ocofaigh ocofaigh merged commit d5d59aa into main Sep 4, 2025
2 checks passed
@ocofaigh ocofaigh deleted the migrate-lz branch September 4, 2025 07:48
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 8.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants