feat: update the default values of subnet and use_public_gateway

[jor2]

Description

update the DA and the module's default value of subnets and use_public_gateways in such a way that a public gateway is attached with each zone.

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[maheshwarishikha]

The modules workload-vpc and management-vpc are to create secured and private VPC aligning with the landing-zone topology. So lets not change anything for those.

Need to make this change only in the root module's default and fully-configurable DA.

[jor2]

/run pipeline

[jor2]

Upgrade test - full failure

        	Error:      	Should be false
        	Test:       	TestRunUpgradeFullyConfigurable
        	Messages:   	Resource(s) identified to be updated 
        	            	Name: subnet
        	            	Address: module.vpc.ibm_is_subnet.subnet["vpc-upg-xmz-vpc-subnet-b"]
        	            	Actions: [update]
        	            	DIFF:
        	            	  Before: 
        	            		{"public_gateway":""}
        	            	  After: 
        	            		{}
        	            	
        	            	Change Detail:
        	            	{
        	            	  "actions": [
        	            	    "update"
        	            	  ],
        	            	  "after": {
        	            	    "access_tags": "SECURE_VALUE_HIDDEN_HASH:-b3f48d82f855c122cd132840cff4beb9ba8a5777c964c413a6af2b62",
        	            	    "available_ipv4_address_count": 248,
        	            	    "crn": "crn:v1:bluemix:public:is:eu-de-2:a/abac0df06b644a9cabc6e44f55b3880e::subnet:02c7-813d55e4-d3b8-46c1-a4e9-52a1d026b040",
        	            	    "id": "02c7-813d55e4-d3b8-46c1-a4e9-52a1d026b040",
        	            	    "ip_version": "ipv4",
        	            	    "ipv4_cidr_block": "10.20.10.0/24",
        	            	    "name": "vpc-upg-xmz-vpc-subnet-b",
        	            	    "network_acl": "r010-457d110f-73b4-4057-97ec-251fa4645a9f",
        	            	    "resource_controller_url": "https://cloud.ibm.com/vpc-ext/network/subnets",
        	            	    "resource_crn": "crn:v1:bluemix:public:is:eu-de-2:a/abac0df06b644a9cabc6e44f55b3880e::subnet:02c7-813d55e4-d3b8-46c1-a4e9-52a1d026b040",
        	            	    "resource_group": "292170bc79c94f5e9019e46fb48f245a",
        	            	    "resource_group_name": "geretain-test-resources",
        	            	    "resource_name": "vpc-upg-xmz-vpc-subnet-b",
        	            	    "resource_status": "available",
        	            	    "routing_table": "r010-8274720c-982a-4c87-9c9a-edea07db25fc",
        	            	    "routing_table_crn": "crn:v1:bluemix:public:is:eu-de:a/abac0df06b644a9cabc6e44f55b3880e::vpc-routing-table:r010-c63fe4f8-c875-40b8-9f93-59025376510d/r010-8274720c-982a-4c87-9c9a-edea07db25fc",
        	            	    "status": "available",
        	            	    "tags": "SECURE_VALUE_HIDDEN_HASH:-c28b270bfa8e50fc9b203d64b08634647d865bca38f930a154607473",
        	            	    "timeouts": null,
        	            	    "total_ipv4_address_count": 256,
        	            	    "vpc": "r010-c63fe4f8-c875-40b8-9f93-59025376510d",
        	            	    "zone": "eu-de-2"
        	            	  },
        	            	  "after_sensitive": {
        	            	    "access_tags": [
        	            	      false,
        	            	      false
        	            	    ],
        	            	    "tags": [
        	            	      false,
        	            	      false
        	            	    ]
        	            	  },
        	            	  "after_unknown": {
        	            	    "access_tags": [
        	            	      false,
        	            	      false
        	            	    ],
        	            	    "public_gateway": true,
        	            	    "tags": [
        	            	      false,
        	            	      false
        	            	    ]
        	            	  },
        	            	  "before": {
        	            	    "access_tags": "SECURE_VALUE_HIDDEN_HASH:-59f39ac4994ad418625890e88348d46e558db836dfc956a046b0c846",
        	            	    "available_ipv4_address_count": 248,
        	            	    "crn": "crn:v1:bluemix:public:is:eu-de-2:a/abac0df06b644a9cabc6e44f55b3880e::subnet:02c7-813d55e4-d3b8-46c1-a4e9-52a1d026b040",
        	            	    "id": "02c7-813d55e4-d3b8-46c1-a4e9-52a1d026b040",
        	            	    "ip_version": "ipv4",
        	            	    "ipv4_cidr_block": "10.20.10.0/24",
        	            	    "name": "vpc-upg-xmz-vpc-subnet-b",
        	            	    "network_acl": "r010-457d110f-73b4-4057-97ec-251fa4645a9f",
        	            	    "public_gateway": "",
        	            	    "resource_controller_url": "https://cloud.ibm.com/vpc-ext/network/subnets",
        	            	    "resource_crn": "crn:v1:bluemix:public:is:eu-de-2:a/abac0df06b644a9cabc6e44f55b3880e::subnet:02c7-813d55e4-d3b8-46c1-a4e9-52a1d026b040",
        	            	    "resource_group": "292170bc79c94f5e9019e46fb48f245a",
        	            	    "resource_group_name": "geretain-test-resources",
        	            	    "resource_name": "vpc-upg-xmz-vpc-subnet-b",
        	            	    "resource_status": "available",
        	            	    "routing_table": "r010-8274720c-982a-4c87-9c9a-edea07db25fc",
        	            	    "routing_table_crn": "crn:v1:bluemix:public:is:eu-de:a/abac0df06b644a9cabc6e44f55b3880e::vpc-routing-table:r010-c63fe4f8-c875-40b8-9f93-59025376510d/r010-8274720c-982a-4c87-9c9a-edea07db25fc",
        	            	    "status": "available",
        	            	    "tags": "SECURE_VALUE_HIDDEN_HASH:-890bfdd6e4e4fba2a1884d6a3cf9bac72512cd52f6f18d8320904d75",
        	            	    "timeouts": null,
        	            	    "total_ipv4_address_count": 256,
        	            	    "vpc": "r010-c63fe4f8-c875-40b8-9f93-59025376510d",
        	            	    "zone": "eu-de-2"
        	            	  },
        	            	  "before_sensitive": {
        	            	    "access_tags": [
        	            	      false,
        	            	      false
        	            	    ],
        	            	    "tags": [
        	            	      false,
        	            	      false
        	            	    ]
        	            	  }
        	            	}
    terraform.go:243: 
        	Error Trace:	/go/pkg/mod/github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper@v1.60.3/testhelper/terraform.go:243
        	            				/go/pkg/mod/github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper@v1.60.3/testschematic/tests.go:273
        	            				/go/pkg/mod/github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper@v1.60.3/testschematic/tests.go:50
        	            				/__w/terraform-ibm-landing-zone-vpc/terraform-ibm-landing-zone-vpc/tests/pr_test.go:378

[jor2]

/run pipeline

[ocofaigh]

@jor2 You can skip the upgrade test, however hold off running the pipeline until #1065 is merged so you can rebase this PR first

[jor2]

/run pipeline

addressed

[terraform-ibm-modules-ops]

🎉 This PR is included in version 8.5.0 🎉

The release is available on:

• GitHub release
• v8.5.0

Your semantic-release bot 📦🚀