test: add prefix to vpc name to avoid name clash #1067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kierramarie
requested review from
maheshwarishikha and
rajatagarwal-ibm
as code owners
toddgiguere
requested changes
Oct 1, 2025
tests/pr_test.go
Outdated
| t.Parallel() | ||
|
|
||
| options := setupOptions(t, "no-prefix-lz", noprefixExampleTerraformDir) | ||
| options.TerraformVars = map[string]interface{}{ |
There was a problem hiding this comment.
setupOptions will have already created a TerraformVars map with region+prefix+etc already set.
In this case you would want to just add a new entry to the existing map, instead of creating a whole new map.
I think you just need one line here, options.TerraformVars["vpc_name"] = fmt.Sprintf("%s-vpc", options.Prefix)
That should add a new vpc_name map entry to the exiting map.
|
/run pipeline |
toddgiguere
approved these changes
Oct 1, 2025
|
/run pipeline |
|
/run pipeline |
|
🎉 This PR is included in version 8.6.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added vpc_name var to No Prefix example. Then pass the prefix and vpc in as the name in the test. Should stop name clash errors.
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers